Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type #4686

Closed
wants to merge 1 commit into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Jul 6, 2021

This code is generated when C1 is profiling types but it is known statically that there should only be one possible class at this point. It's supposed to then store the klass pointer into the method data when the expected class is actually observed but currently it does a load instead of a store.

I've attached a simple example to the JBS entry that shows the correct method data after changing LDR to STR. Also tested tier1 on AArch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4686/head:pull/4686
$ git checkout pull/4686

Update a local copy of the PR:
$ git checkout pull/4686
$ git pull https://git.openjdk.java.net/jdk pull/4686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4686

View PR using the GUI difftool:
$ git pr show -t 4686

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4686.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 6, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@nick-arm The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jul 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 6, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewed-by: aph, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 4dfcf53: 8269935: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on windows
  • 1578979: 8269917: Insert missing commas in copyrights in java.net
  • 326b2e1: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation
  • f485171: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE
  • 16aa8cb: 8269697: JNI_GetPrimitiveArrayCritical() should not accept object array
  • e47803a: 8266310: deadlock between System.loadLibrary and JNI FindClass loading another class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 6, 2021
@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit 3d090e7.
Since your change was applied there have been 19 commits pushed to the master branch:

  • a9e2010: 8268425: Show decimal nid of OSThread instead of hex format one
  • 01c29d8: 8266407: remove jdk.internal.javac.PreviewFeature.Feature.SEALED_CLASSES
  • 7a4f08a: Merge
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/20eba35515073c4daf1fa8ac78a37196ea196690...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@nick-arm Pushed as commit 3d090e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants