Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269914: Factor out heap printing for G1 young and full gc #4689

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 6, 2021

Hi all,

can I have reviews for this change that factors out before/after heap related printing into a single scoped object to be used for both young and full gc code?

There is some minor change in order of unrelated options (COMMIT/UNCOMMIT region state changes vs. other heap printing), during full gc but since this is very low level debugging I do not see a problem to do that.

Based on #4539 .

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Dependency #4539 must be integrated first

Issue

  • JDK-8269914: Factor out heap printing for G1 young and full gc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4689/head:pull/4689
$ git checkout pull/4689

Update a local copy of the PR:
$ git checkout pull/4689
$ git pull https://git.openjdk.java.net/jdk pull/4689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4689

View PR using the GUI difftool:
$ git pr show -t 4689

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4689.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/4539 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2021
@openjdk
Copy link

openjdk bot commented Jul 6, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 6, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2021

Webrevs

@tschatzl tschatzl closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant