8269914: Factor out heap printing for G1 young and full gc #4689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
can I have reviews for this change that factors out before/after heap related printing into a single scoped object to be used for both young and full gc code?
There is some minor change in order of unrelated options (COMMIT/UNCOMMIT region state changes vs. other heap printing), during full gc but since this is very low level debugging I do not see a problem to do that.
Based on #4539 .
Thanks,
Thomas
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4689/head:pull/4689
$ git checkout pull/4689
Update a local copy of the PR:
$ git checkout pull/4689
$ git pull https://git.openjdk.java.net/jdk pull/4689/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4689
View PR using the GUI difftool:
$ git pr show -t 4689
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4689.diff