8263538: SharedArchiveConsistency.java should test -Xshare:auto as well

[yminqi]

Hi, please review

When this test run with -Xshare:on, it will exit when the shared archive is corrupted or mismatch. Make it run with -Xshare:auto will expand code coverage and to keep app run without using the CDS.

Tests: Mach5 tier1,tier4

Thanks
Yumin

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263538: SharedArchiveConsistency.java should test -Xshare:auto as well

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4694/head:pull/4694
$ git checkout pull/4694

Update a local copy of the PR:
$ git checkout pull/4694
$ git pull https://git.openjdk.java.net/jdk pull/4694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4694

View PR using the GUI difftool:
$ git pr show -t 4694

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4694.diff

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yminqi The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8544e5dd)
• 00: Full (7d59a4ea)

[iklam]

LGTM.

[openjdk]

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263538: SharedArchiveConsistency.java should test -Xshare:auto as well

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 4dfcf53: 8269935: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

Looks good.

[yminqi]

@iklam @calvinccheung Thanks for review!
/integrate

[openjdk]

Going to push as commit e8206db.
Since your change was applied there has been 1 commit pushed to the master branch:

• 4dfcf53: 8269935: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on windows

Your commit was automatically rebased without conflicts.

[openjdk]

@yminqi Pushed as commit e8206db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.