Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8252859: Inconsistent use of alpha in class AbsSeq #47

Closed
wants to merge 1 commit into from
Closed

8252859: Inconsistent use of alpha in class AbsSeq #47

wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Sep 7, 2020 •
edited by openjdk bot
Loading

Invert the meaning of _alpha, from alpha to 1-alpha.

Test: I instrumented the constructor of AbsSeq with printf("%f\n", _alpha) onto master and printf("%f\n", 1.0 - _alpha) after the patch, and checked the output of java <useXgc> --version (G1, Parallel, Shenandoah, and Z) are the same before and after.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252859: Inconsistent use of alpha in class AbsSeq

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/47/head:pull/47
$ git checkout pull/47

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@albertnetymk The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review labels Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020 •
edited
Loading

Webrevs

@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Mailing list message from Thomas Schatzl on hotspot-dev:

Hi,

On 07.09.20 12:59, Albert Mingkun Yang wrote:

8252859: Inconsistent use of alpha in class AbsSeq

could you please give *some* explanation in the PR description as
before? Thanks.

- G1AdaptiveIHOPControl::_marking_times_s and _allocation_rate_s were
not updated.

- Testing?

Looks good otherwise.

Thanks,
Thomas

@albertnetymk
Copy link
Member Author

Thomas, thank you for the review. Updated.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252859: Inconsistent use of alpha in class AbsSeq

Reviewed-by: tschatzl, sjohanss
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch:

  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • 8d6d43c: 8251193: bin/idea.sh is generating wrong folder definitions for JVMCI modules
  • 70d5cac: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • e0d5b5f: 8252627: Make it safe for JFR thread to read threadObj
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4fb1980fd0539230fdc310aad63bbda8cb1725e6.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Mailing list message from Thomas Schatzl on hotspot-dev:

Hi,

On 07.09.20 13:59, Albert Mingkun Yang wrote:

lgtm.

Thomas

@albertnetymk
Copy link
Member Author

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@albertnetymk
The hotspot-gc label was successfully added.

kstefanj
kstefanj approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning this up.

@albertnetymk
Copy link
Member Author

Stefan, thank you for the review.

@albertnetymk
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@albertnetymk
Your change (at version 89df9a5) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

tschatzl commented Sep 8, 2020

/sponsor

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@tschatzl @albertnetymk Since your change was applied there have been 11 commits pushed to the master branch:

  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • 8d6d43c: 8251193: bin/idea.sh is generating wrong folder definitions for JVMCI modules
  • 70d5cac: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • e0d5b5f: 8252627: Make it safe for JFR thread to read threadObj
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7600274.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the alpha branch September 8, 2020 11:19
robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023
@luhenry
Remove dead code (openjdk#47)
4700525
asotona pushed a commit to asotona/jdk that referenced this pull request Apr 17, 2024
@igraves
Adding String Concatenation to Code Model (openjdk#47)
a5c4db1 
* Initial commit

* Shortening up tests and minor tweaks

* Test tweak

* Test cleanups

* Updates and cleanup

* Removing unused var

* Tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstefanj kstefanj kstefanj approved these changes

@tschatzl tschatzl tschatzl approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @tschatzl @kstefanj