Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers #4700

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented Jul 7, 2021

…ocess cpu usage inside a container


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4700/head:pull/4700
$ git checkout pull/4700

Update a local copy of the PR:
$ git checkout pull/4700
$ git pull https://git.openjdk.java.net/jdk pull/4700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4700

View PR using the GUI difftool:
$ git pr show -t 4700

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4700.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2021

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2021
@openjdk
Copy link

openjdk bot commented Jul 7, 2021

@xpbob The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jul 7, 2021
@xpbob
Copy link
Contributor Author

xpbob commented Jul 7, 2021

/issue add JDK-8269851
/label add containers

@openjdk openjdk bot changed the title 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect pr… 8269851: OperatingSystemMXBean getProcessCpuLoad reports Process CPU usage Jul 7, 2021
@openjdk
Copy link

openjdk bot commented Jul 7, 2021

@xpbob This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jul 7, 2021

@xpbob The label containers is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@mlbridge
Copy link

mlbridge bot commented Jul 7, 2021

Webrevs

@xpbob
Copy link
Contributor Author

xpbob commented Jul 7, 2021

getProcessCpuLoad return jvm cpu load。
8 core in machine, set 1 core for container。
Run same program, the getProcessCpuLoad return the same value。

expected
same program run in machine,value 0.12
run in 1 core container,value 0.99

@xpbob
Copy link
Contributor Author

xpbob commented Jul 7, 2021

ProcessCpuLoad is associative container setting

@dholmes-ora
Copy link
Member

@YaSuenag and @jerboaa could you please take a look at this one.

@xpbob xpbob changed the title 8269851: OperatingSystemMXBean getProcessCpuLoad reports Process CPU usage 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers Jul 7, 2021
@xpbob xpbob closed this Jul 7, 2021
@dholmes-ora
Copy link
Member

This has moved to #4702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jmx jmx-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants