Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags #4706

Closed
wants to merge 1 commit into from

Conversation

thejasviv
Copy link
Member

@thejasviv thejasviv commented Jul 7, 2021

Hi,

Please review this simple change to remove redundancy of @run tags. The test "java/net/httpclient/DigestEchoClientSSL.java" contains a couple of redundant @run tags:

  • @run main/othervm/timeout=300
  • DigestEchoClientSSL SSL
  • @run main/othervm/timeout=300
  • DigestEchoClientSSL SSL
  • @run main/othervm/timeout=300
  • -Djdk.http.auth.proxying.disabledSchemes=
  • -Djdk.http.auth.tunneling.disabledSchemes=
  • DigestEchoClientSSL SSL PROXY
  • @run main/othervm/timeout=300
  • -Djdk.http.auth.proxying.disabledSchemes=
  • -Djdk.http.auth.tunneling.disabledSchemes=
  • DigestEchoClientSSL SSL PROXY

This change is to remove the redundancy. I have run the test and verified that it passes on all platforms following the change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4706/head:pull/4706
$ git checkout pull/4706

Update a local copy of the PR:
$ git checkout pull/4706
$ git pull https://git.openjdk.java.net/jdk pull/4706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4706

View PR using the GUI difftool:
$ git pr show -t 4706

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4706.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 7, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@thejasviv The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Jul 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 7, 2021

Webrevs

dfuch
dfuch approved these changes Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags

Reviewed-by: dfuchs, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • d1cecaa: 8269481: SctpMultiChannel never releases own file descriptor
  • 2209e3e: 8270027: ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on macOS-x64
  • 2dc5486: 8267303: Replace MinObjectAlignmentSize usages for non-Java heap objects
  • 3586a23: 8268635: Corrupt oop in ClassLoaderData
  • bffb1a7: 8269923: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java failed with "FATAL ERROR in native method: Primitive type array expected but not received for JNI array operation"
  • 77a5b7b: 8269761: idea.sh missing .exe suffix when invoking javac on WSL
  • 248aa50: 8269294: Verify_before/after_young_collection should execute all verification
  • 18b80c7: 8269908: Move MemoryService::track_memory_usage call into G1MonitoringScope
  • a685011: 8269022: Put evacuation failure string directly into gc=info log message
  • 72530ef: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @vyommani) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 7, 2021
Copy link
Contributor

@vyommani vyommani left a comment

Looks OK to me.

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Jul 7, 2021

/integrate

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Jul 7, 2021

@vyommani , @dfuch , would one of you please sponsor this PR?

@openjdk openjdk bot added the sponsor label Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@thejasviv
Your change (at version 7296d71) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Jul 8, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit 4e18ec2.
Since your change was applied there have been 22 commits pushed to the master branch:

  • e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
  • 270fbcb: Merge
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
  • 6000950: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
  • 1f2bf1d: 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode
  • 7fcd5ca: 8266036: class file for sun.misc.Contended not found
  • a49b1dc: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • 820f290: 8268859: jshell throws exception while parsing illegal "case true"
  • 815e4af: 8269802: javac fails to compile nested pattern matching switches
  • 2daf39a: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/3d090e7ee561252027c06021b337c69a39f724e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@akolarkunnu @thejasviv Pushed as commit 4e18ec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
4 participants