Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java #4707

Closed
wants to merge 1 commit into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 7, 2021

Fixed the log decorator, and added checks for non-empty statistics.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4707/head:pull/4707
$ git checkout pull/4707

Update a local copy of the PR:
$ git checkout pull/4707
$ git pull https://git.openjdk.java.net/jdk pull/4707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4707

View PR using the GUI difftool:
$ git pr show -t 4707

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4707.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 7, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 7, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • bffb1a7: 8269923: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java failed with "FATAL ERROR in native method: Primitive type array expected but not received for JNI array operation"
  • 77a5b7b: 8269761: idea.sh missing .exe suffix when invoking javac on WSL

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 7, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 8, 2021

Thanks for the review.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit 4a45d95.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
  • 2c883ee: 8267982: Set the node after peephole optimization to be removed
  • 4fbcce1: 8269886: Inaccurate error message for compressed hprof test
  • a96012f: 8269803: G1: remove unnecessary NoRefDiscovery
  • 4e18ec2: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
  • 270fbcb: Merge
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
  • 6000950: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
  • 1f2bf1d: 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/248aa5014b6fc5ef4d3de1feca62aa82ed55b8ba...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@albertnetymk Pushed as commit 4a45d95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the plab branch Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants