Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253904: Revert Tokenizer improvements JDK-8224225 #471

Closed
wants to merge 1 commit into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Oct 1, 2020

This reverts commit 90c131f.

Github test gave false positive.

https://bugs.openjdk.java.net/browse/JDK-8253904

https://github.com/JimLaskey/jdk/actions/runs/282419921


Sorry for the inconvenience.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253904: Revert Tokenizer improvements JDK-8224225

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/471/head:pull/471
$ git checkout pull/471

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2020

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@JimLaskey JimLaskey changed the title 8253904: Revert Tokenizer improvements 8253904: Revert Tokenizer improvements JDK-8224225 Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@JimLaskey The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Oct 1, 2020
@JimLaskey JimLaskey marked this pull request as ready for review October 1, 2020 17:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253904: Revert Tokenizer improvements JDK-8224225

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020
@JimLaskey
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@JimLaskey Pushed as commit 8fda5b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 1, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants