8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

[fguallini]

test/jdk/javax/net/ssl/compatibility/JdkInfo is a helper class for the compatibility tests. It is verifying whether a protocol or cipher suite is supported/enabled by setting all the allowed values as a string, and then invoking String contains() to return whether a specific version is supported. This approach is problematic when, for instance, supportedProtocols is equal to 'TLSv1.3,TLSv1.2', then supportedProtocols.contains("TLSv1") will return true, given that 'TLSv1' is effectively a substring of 'TLSv1.3'.

Proposed fix: Set the supported/enabled protocols and ciphers as elements in lists, and use List contains() to find matches

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4710/head:pull/4710
$ git checkout pull/4710

Update a local copy of the PR:
$ git checkout pull/4710
$ git pull https://git.openjdk.java.net/jdk pull/4710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4710

View PR using the GUI difftool:
$ git pr show -t 4710

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4710.diff

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (42b7da1e)

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support

Reviewed-by: xuelei, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• bca570c: 8269962: SA has unused Hashtable, Dictionary classes
• 4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
• 30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
• 2c883ee: 8267982: Set the node after peephole optimization to be removed
• 4fbcce1: 8269886: Inaccurate error message for compressed hprof test
• a96012f: 8269803: G1: remove unnecessary NoRefDiscovery
• 4e18ec2: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
• e54585b: 8268363: AArch64: Implement string_indexof_char intrinsic in SVE
• 270fbcb: Merge
• c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/77a5b7b27e36457cf63be45b3e4f120abad57d4a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version 42b7da1) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit 6346793.
Since your change was applied there have been 152 commits pushed to the master branch:

• 1eeb179: Merge
• 61359c4: 8270993: Missing forward declaration of ZeroFrame
• 8e8e87a: 8268223: Problemlist vmTestbase/nsk/jdi/HiddenClass/events/events001.java
• 845c31d: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC
• 0cec11d: 8270307: C2: assert(false) failed: bad AD file after JDK-8267687
• 38694aa: 8270939: ProblemList java/lang/invoke/RicochetTest.java until JDK-8251969 is fixed
• 754352f: 8270340: Base64 decodeBlock intrinsic for Power64 needs cleanup
• 8cd0769: 8270875: Deprecate the FilterSpuriousWakeups flag so it can be removed
• 534f005: 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"
• 00195b8: 8265604: Support unlinked classes in dynamic CDS archive
• ... and 142 more: https://git.openjdk.java.net/jdk/compare/77a5b7b27e36457cf63be45b3e4f120abad57d4a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @fguallini Pushed as commit 6346793.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.