8269418: jdk/jfr/event/oldobject/TestObjectSize.java failed with "RuntimeException: No events: expected false, was true" #4712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Greetings,
please help review these adjustments to make the test more robust, i.e. neither trap on an invalid assertion nor timeout because of too many retries.
Testing: jdk_jfr (300 times)
Thanks
Markus
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4712/head:pull/4712
$ git checkout pull/4712
Update a local copy of the PR:
$ git checkout pull/4712
$ git pull https://git.openjdk.java.net/jdk pull/4712/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4712
View PR using the GUI difftool:
$ git pr show -t 4712
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4712.diff