Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers. #472

Closed

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Oct 1, 2020

This change allows JVMCI compilers to append an entry with flexible dispatch offset to the implicit exception table.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/472/head:pull/472
$ git checkout pull/472

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 1, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2020

Hi @mur47x111, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mur47x111" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@mur47x111 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 1, 2020
@mur47x111 mur47x111 changed the title 8253842: Allow implicit exception to dispatch to other address in jvmci compilers. 8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers. Oct 1, 2020
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Oct 2, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2020

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2020
@mur47x111
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 5, 2020
@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@mur47x111
Your change (at version fe63251) is now ready to be sponsored by a Committer.

@dougxc
Copy link
Member

dougxc commented Oct 5, 2020

/sponsor

@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2020
@openjdk
Copy link

openjdk bot commented Oct 5, 2020

@dougxc @mur47x111 Since your change was applied there have been 57 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 5d4a135.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants