Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes #4720

Closed
wants to merge 1 commit into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 8, 2021

Simple change of removing a null check.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4720/head:pull/4720
$ git checkout pull/4720

Update a local copy of the PR:
$ git checkout pull/4720
$ git pull https://git.openjdk.java.net/jdk pull/4720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4720

View PR using the GUI difftool:
$ git pr show -t 4720

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4720.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • 5832882: 8269827: JMH tests for AES/GCM byte[] and bytebuffers
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/2c883eeed4a5276bb4b0dc3d2ffc4d9151662f6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 8, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

Loading

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 9, 2021

Thanks for the review.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit 3d193ad.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 676f1d7: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • c93204c: 8269914: Factor out heap printing for G1 young and full gc
  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/2c883eeed4a5276bb4b0dc3d2ffc4d9151662f6b...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@albertnetymk Pushed as commit 3d193ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the rp-timer branch Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants