Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode #4725

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 8, 2021

Found this while testing Shenandoah with Zero. This configuration takes a lot of time, and eventually times out:

$ time CONF=linux-x86_64-server-fastdebug make run-test TEST=gc/shenandoah/TestRefprocSanity.java TEST_OPTS="JAVA_OPTIONS=-Xint"
<timeout after 1200 seconds>

With these fixes, the run time with -Xint is under 1 minute:

real	0m51.472s
user	3m0.366s
sys	0m5.473s

In default mode, the run time is now under 20 seconds:

real	0m20.584s
user	1m8.693s
sys	0m5.030s

This also passes with Zero (plus some Zero fixes) now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4725/head:pull/4725
$ git checkout pull/4725

Update a local copy of the PR:
$ git checkout pull/4725
$ git pull https://git.openjdk.java.net/jdk pull/4725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4725

View PR using the GUI difftool:
$ git pr show -t 4725

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4725.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2021

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • bca570c: 8269962: SA has unused Hashtable, Dictionary classes
  • 4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
  • 30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
  • 2c883ee: 8267982: Set the node after peephole optimization to be removed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2021
@shipilev
Copy link
Member Author

shipilev commented Jul 8, 2021

Thanks! There is only one unrelated failure in GHA testing.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

Going to push as commit 4f322a9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • bca570c: 8269962: SA has unused Hashtable, Dictionary classes
  • 4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
  • 30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
  • 2c883ee: 8267982: Set the node after peephole optimization to be removed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev Pushed as commit 4f322a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8270096-refprocsanity-int branch Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants