-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8270094: Shenandoah: Provide human-readable labels for test configurations #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
zhengyu123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 676f1d7.
Your commit was automatically rebased without conflicts. |
hotspot_gc_shenandoahcontains a lot of parallel test configurations, and it would be much nicer to have them named appropriately, rather than just #id1...#id2.Additional testing:
hotspot_gc_shenandoah, eyeballing test namesProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4726/head:pull/4726$ git checkout pull/4726Update a local copy of the PR:
$ git checkout pull/4726$ git pull https://git.openjdk.java.net/jdk pull/4726/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4726View PR using the GUI difftool:
$ git pr show -t 4726Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4726.diff