Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jul 8, 2021

hotspot_gc_shenandoah contains a lot of parallel test configurations, and it would be much nicer to have them named appropriately, rather than just #id1...#id2.

Additional testing:

  • hotspot_gc_shenandoah, eyeballing test names

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270094: Shenandoah: Provide human-readable labels for test configurations

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4726/head:pull/4726
$ git checkout pull/4726

Update a local copy of the PR:
$ git checkout pull/4726
$ git pull https://git.openjdk.java.net/jdk pull/4726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4726

View PR using the GUI difftool:
$ git pr show -t 4726

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4726.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2021

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270094: Shenandoah: Provide human-readable labels for test configurations

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4a45d95: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java
  • 30bba54: 8270064: Problem list tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java due to JDK-8270060
  • 2c883ee: 8267982: Set the node after peephole optimization to be removed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2021
@shipilev
Copy link
Member Author

shipilev commented Jul 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2021

Going to push as commit 676f1d7.
Since your change was applied there have been 17 commits pushed to the master branch:

  • c93204c: 8269914: Factor out heap printing for G1 young and full gc
  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/4fbcce119b1736455cb74d0a585097eca617593c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 9, 2021
@openjdk
Copy link

openjdk bot commented Jul 9, 2021

@shipilev Pushed as commit 676f1d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8270094-sh-readable branch August 3, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants