Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270110: Shenandoah: Add test for JDK-8269661 #4740

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 9, 2021

I would like to add a test for JDK-8269661.

Currently, JDK-8269661 only affects Shenandoah GC, as it is the only GC supports object pinning and string deduplication.

Test:

  • new test passes with JDK-8269661, fails after backout JDK-8269661 fix.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4740/head:pull/4740
$ git checkout pull/4740

Update a local copy of the PR:
$ git checkout pull/4740
$ git pull https://git.openjdk.java.net/jdk pull/4740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4740

View PR using the GUI difftool:
$ git pr show -t 4740

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4740.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2021
@openjdk
Copy link

openjdk bot commented Jul 9, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270110: Shenandoah: Add test for JDK-8269661

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 8973867: 8269295: Verification time before/after young collection only covers parts of the verification
  • 6a9bc10: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • 86a2008: 8051680: (ref) unnecessary process_soft_ref_reconsider
  • ac75a53: 8253779: Amalloc may be wasting space by overaligning
  • 68b6e11: 8270083: -Wnonnull errors happen with GCC 11.1.1
  • ec975c6: Merge
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

Going to push as commit 548bb31.
Since your change was applied there have been 31 commits pushed to the master branch:

  • c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
  • 7cbb67a: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 8973867: 8269295: Verification time before/after young collection only covers parts of the verification
  • 6a9bc10: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • 86a2008: 8051680: (ref) unnecessary process_soft_ref_reconsider
  • ac75a53: 8253779: Amalloc may be wasting space by overaligning
  • 68b6e11: 8270083: -Wnonnull errors happen with GCC 11.1.1
  • ec975c6: Merge
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@zhengyu123 Pushed as commit 548bb31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants