Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270169: G1: Incorrect reference discovery MT degree in concurrent marking #4741

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 9, 2021

Simple change of ref discovery MT degree in concurrent marking.

Test: hotspot_gc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270169: G1: Incorrect reference discovery MT degree in concurrent marking

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4741/head:pull/4741
$ git checkout pull/4741

Update a local copy of the PR:
$ git checkout pull/4741
$ git pull https://git.openjdk.java.net/jdk pull/4741/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4741

View PR using the GUI difftool:
$ git pr show -t 4741

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4741.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270169: G1: Incorrect reference discovery MT degree in concurrent marking

Reviewed-by: tschatzl, iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 8973867: 8269295: Verification time before/after young collection only covers parts of the verification
  • 6a9bc10: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • 86a2008: 8051680: (ref) unnecessary process_soft_ref_reconsider
  • ac75a53: 8253779: Amalloc may be wasting space by overaligning
  • 68b6e11: 8270083: -Wnonnull errors happen with GCC 11.1.1
  • ec975c6: Merge
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 12, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

Going to push as commit 7d2825e.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
  • 548bb31: 8270110: Shenandoah: Add test for JDK-8269661
  • c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
  • 7cbb67a: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 8973867: 8269295: Verification time before/after young collection only covers parts of the verification
  • 6a9bc10: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • 86a2008: 8051680: (ref) unnecessary process_soft_ref_reconsider
  • ac75a53: 8253779: Amalloc may be wasting space by overaligning
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@albertnetymk Pushed as commit 7d2825e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the cm-rp branch Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
4 participants