Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests #4742

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 9, 2021

Please review this trivial patch to cleanup TestStringDedup and TestStringDedupStress tests, removes unused Unsafe usages.

Test:

  • Both tests still pass

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4742/head:pull/4742
$ git checkout pull/4742

Update a local copy of the PR:
$ git checkout pull/4742
$ git pull https://git.openjdk.java.net/jdk pull/4742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4742

View PR using the GUI difftool:
$ git pr show -t 4742

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4742.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Jul 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Ah yes, java.lang:open already provides this. Good!

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 3d193ad: 8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes
  • 676f1d7: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • c93204c: 8269914: Factor out heap printing for G1 young and full gc
  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Jul 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit e4c24f0.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 3588634: 8268420: new Reporter method to report a diagnostic within a DocTree node
  • 5a74291: 8266565: Spec of ForwardingJavaFileManager/ForwardingFileObject/ForwardingJavaFileObject methods should mention delegation instead of being copied
  • 3d193ad: 8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes
  • 676f1d7: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • c93204c: 8269914: Factor out heap printing for G1 young and full gc
  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/58328824927292927a2c6329400cde816c383ecd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@zhengyu123 Pushed as commit e4c24f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants