Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265443: IGV: disambiguate groups by emiting additional properties #4743

Closed
wants to merge 1 commit into from

Conversation

jtfuller111
Copy link
Contributor

@jtfuller111 jtfuller111 commented Jul 9, 2021

Added compilation id and whether the compilation is OSR or not to the IdealGraphPrinter's output. Are there any other properties that should also be emitted?

Here is a screenshot of how the properties appear in IGV:
image


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265443: IGV: disambiguate groups by emiting additional properties

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4743/head:pull/4743
$ git checkout pull/4743

Update a local copy of the PR:
$ git checkout pull/4743
$ git pull https://git.openjdk.java.net/jdk pull/4743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4743

View PR using the GUI difftool:
$ git pr show -t 4743

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4743.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2021

👋 Welcome back jtfuller111! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2021
@openjdk
Copy link

openjdk bot commented Jul 9, 2021

@jtfuller111 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@jtfuller111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265443: IGV: disambiguate groups by emiting additional properties

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 691 new commits pushed to the master branch:

  • f644365: 8269689: Update --release 17 symbol information for JDK 17 build 31
  • 3fc761d: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it
  • a8f1542: 8270455: Remove unused JFR tracer related code in G1CollectedHeap
  • edff556: 8263385: IGV: Graph is not opened in the window that has focus.
  • e7cdfeb: 8270862: Fix problem list entries for 32-bit
  • f8ec3b6: 8270801: Print VM arguments with java -Xlog:arguments
  • a5c9094: Merge
  • 2dddcce: 8270858: Problem List java/awt/Window/MultiWindowApp/MultiWindowAppTest.java on Linux
  • 1350e2b: 8270556: Exclude security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA
  • 58f1ada: 8269636: Change outputStream's print_raw() and print_raw_cr() second parameter to size_t type
  • ... and 681 more: https://git.openjdk.java.net/jdk/compare/ccfcd926674ee0bd88f34b16b489abe008169b11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2021
@jtfuller111
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 19, 2021
@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@jtfuller111
Your change (at version d2b0c8c) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2021

@jtfuller111 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 8, 2021

Going to push as commit f2f8136.
Since your change was applied there have been 1239 commits pushed to the master branch:

  • 59c9f75: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • faa942c: 8273000: Remove WeakReference-based class initialisation barrier implementation
  • 21012f2: 8078641: MethodHandle.asTypeCache can retain classes from unloading
  • 1855574: 8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel)
  • 6750c34: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • a66629a: 8254167: G1: Record regions where evacuation failed to provide targeted iteration
  • 286a1f6: 8273440: Zero: Disable runtime/Unsafe/InternalErrorTest.java
  • 7d24a33: 8273318: Some containers/docker/TestJFREvents.java configs are running out of memory
  • 1513dc7: 8271603: Unnecessary Vector usage in java.desktop
  • ea4907a: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out
  • ... and 1229 more: https://git.openjdk.java.net/jdk/compare/ccfcd926674ee0bd88f34b16b489abe008169b11...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@TobiHartmann @jtfuller111 Pushed as commit f2f8136.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants