Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas #4746

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jul 9, 2021

Please review this simple test addition. It adds more coverage toJavaName() for generated classes for lambdas.

Testing: jtreg:test/hotspot/jtreg/compiler/jvmci

Thoughts?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4746/head:pull/4746
$ git checkout pull/4746

Update a local copy of the PR:
$ git checkout pull/4746
$ git pull https://git.openjdk.java.net/jdk pull/4746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4746

View PR using the GUI difftool:
$ git pr show -t 4746

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4746.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 9, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@jerboaa The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jul 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 9, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Okay.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 7bfa39f: 8270108: Update JCov version to 3.0.9
  • e4c24f0: 8270171: Shenandoah: Cleanup TestStringDedup and TestStringDedupStress tests
  • 3588634: 8268420: new Reporter method to report a diagnostic within a DocTree node
  • 5a74291: 8266565: Spec of ForwardingJavaFileManager/ForwardingFileObject/ForwardingJavaFileObject methods should mention delegation instead of being copied
  • 3d193ad: 8270082: Remove unnecessary gc_timer null check in ReferenceProcessorPhaseTimes
  • 676f1d7: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • c93204c: 8269914: Factor out heap printing for G1 young and full gc
  • dfd6b2b: Merge
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/248aa5014b6fc5ef4d3de1feca62aa82ed55b8ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 9, 2021
@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jul 12, 2021

Thanks for the review!

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jul 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

Going to push as commit 6a9bc10.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 86a2008: 8051680: (ref) unnecessary process_soft_ref_reconsider
  • ac75a53: 8253779: Amalloc may be wasting space by overaligning
  • 68b6e11: 8270083: -Wnonnull errors happen with GCC 11.1.1
  • ec975c6: Merge
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • 62ff55d: 8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines
  • 46c610c: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/248aa5014b6fc5ef4d3de1feca62aa82ed55b8ba...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@jerboaa Pushed as commit 6a9bc10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
2 participants