8270282: Semantically rename reference processing subphases #4752

albertnetymk · 2021-07-12T10:24:32Z

Simple rename of phase{2,3,4} to something with semantic meaning.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8270282: Semantically rename reference processing subphases

Reviewers

Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 49a4e27
Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 49a4e27

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4752/head:pull/4752
$ git checkout pull/4752

Update a local copy of the PR:
$ git checkout pull/4752
$ git pull https://git.openjdk.java.net/jdk pull/4752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4752

View PR using the GUI difftool:
$ git pr show -t 4752

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4752.diff

bridgekeeper · 2021-07-12T10:25:01Z

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-07-12T10:27:22Z

@albertnetymk The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-07-12T10:32:07Z

Webrevs

01: Full - Incremental (42f38910)
00: Full (49a4e277)

kimbarrett

Mostly looks good, except for a naming choice.

kimbarrett · 2021-07-12T12:17:48Z

src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp

@@ -80,7 +80,7 @@ class ReferenceProcessorPhaseTimes : public CHeapObj<mtGC> {
  ReferenceProcessorPhaseTimes(GCTimer* gc_timer, uint max_gc_threads);
  ~ReferenceProcessorPhaseTimes();

-  WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
+  WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }


This is a weird function name. I understand why, but I'm not convinced. We have process_soft_weak_final_refs and the like, for example.

How about soft_weak_final_refs_phase_worker_time_sec()?

Yes, that's normal style. It's quite a mouthful, but it's not like it gets written very often. With that change, I think this PR looks good.

Agree with that.

kimbarrett

Looks good after discussed function name change.

openjdk · 2021-07-12T22:39:28Z

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270282: Semantically rename reference processing subphases

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

07e9052: 8270056: Generated lambda class can not access protected static method of target class
afe957c: 8268698: Use Objects.check{Index,FromToIndex,FromIndexSize} for java.base
a4e5f08: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump
353e9c8: 8270320: JDK-8270110 committed invalid copyright headers
7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking
41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
1aef372: 8266578: Disambiguate BigDecimal description of scale
92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
548bb31: 8270110: Shenandoah: Add test for JDK-8269661
c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
... and 3 more: https://git.openjdk.java.net/jdk/compare/86a20081aefb6d43dc8a4d404adb2c1fb5729585...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

tschatzl

Lgtm apart from that naming issue.

tschatzl · 2021-07-13T07:31:50Z

src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp

@@ -80,7 +80,7 @@ class ReferenceProcessorPhaseTimes : public CHeapObj<mtGC> {
  ReferenceProcessorPhaseTimes(GCTimer* gc_timer, uint max_gc_threads);
  ~ReferenceProcessorPhaseTimes();

-  WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
+  WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }


Agree with that.

albertnetymk · 2021-07-13T10:35:41Z

Thanks for the review.

/integrate

openjdk · 2021-07-13T10:37:11Z

Going to push as commit 565ec85.
Since your change was applied there have been 13 commits pushed to the master branch:

07e9052: 8270056: Generated lambda class can not access protected static method of target class
afe957c: 8268698: Use Objects.check{Index,FromToIndex,FromIndexSize} for java.base
a4e5f08: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump
353e9c8: 8270320: JDK-8270110 committed invalid copyright headers
7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking
41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
1aef372: 8266578: Disambiguate BigDecimal description of scale
92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
548bb31: 8270110: Shenandoah: Add test for JDK-8269661
c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
... and 3 more: https://git.openjdk.java.net/jdk/compare/86a20081aefb6d43dc8a4d404adb2c1fb5729585...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-13T10:37:26Z

@albertnetymk Pushed as commit 565ec85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

phase1-rename

49a4e27

openjdk bot added the rfr label Jul 12, 2021

openjdk bot added the hotspot-gc label Jul 12, 2021

kimbarrett reviewed Jul 12, 2021

View changes

kimbarrett approved these changes Jul 12, 2021

View changes

openjdk bot added the ready label Jul 12, 2021

tschatzl approved these changes Jul 13, 2021

View changes

rename method name

42f3891

openjdk bot closed this Jul 13, 2021

openjdk bot added integrated and removed ready rfr labels Jul 13, 2021

albertnetymk deleted the phase1-rename branch Jul 13, 2021

8270282: Semantically rename reference processing subphases #4752

8270282: Semantically rename reference processing subphases #4752

albertnetymk commented Jul 12, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Jul 12, 2021

openjdk bot commented Jul 12, 2021

mlbridge bot commented Jul 12, 2021 •

edited

kimbarrett left a comment

kimbarrett Jul 12, 2021

albertnetymk Jul 12, 2021

kimbarrett Jul 12, 2021

tschatzl Jul 13, 2021

kimbarrett left a comment

openjdk bot commented Jul 12, 2021 •

edited

tschatzl left a comment

tschatzl Jul 13, 2021

albertnetymk commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

8270282: Semantically rename reference processing subphases #4752

8270282: Semantically rename reference processing subphases #4752

Conversation

albertnetymk commented Jul 12, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 12, 2021

openjdk bot commented Jul 12, 2021

mlbridge bot commented Jul 12, 2021 • edited

Webrevs

kimbarrett left a comment

kimbarrett Jul 12, 2021

Choose a reason for hiding this comment

albertnetymk Jul 12, 2021

Choose a reason for hiding this comment

kimbarrett Jul 12, 2021

Choose a reason for hiding this comment

tschatzl Jul 13, 2021

Choose a reason for hiding this comment

kimbarrett left a comment

openjdk bot commented Jul 12, 2021 • edited

tschatzl left a comment

tschatzl Jul 13, 2021

Choose a reason for hiding this comment

albertnetymk commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

albertnetymk commented Jul 12, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Jul 12, 2021 •

edited

openjdk bot commented Jul 12, 2021 •

edited