Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270282: Semantically rename reference processing subphases #4752

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 12, 2021

Simple rename of phase{2,3,4} to something with semantic meaning.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270282: Semantically rename reference processing subphases

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4752/head:pull/4752
$ git checkout pull/4752

Update a local copy of the PR:
$ git checkout pull/4752
$ git pull https://git.openjdk.java.net/jdk pull/4752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4752

View PR using the GUI difftool:
$ git pr show -t 4752

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4752.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Mostly looks good, except for a naming choice.

@@ -80,7 +80,7 @@ class ReferenceProcessorPhaseTimes : public CHeapObj<mtGC> {
ReferenceProcessorPhaseTimes(GCTimer* gc_timer, uint max_gc_threads);
~ReferenceProcessorPhaseTimes();

WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird function name. I understand why, but I'm not convinced. We have process_soft_weak_final_refs and the like, for example.

Copy link
Member Author

@albertnetymk albertnetymk Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about soft_weak_final_refs_phase_worker_time_sec()?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's normal style. It's quite a mouthful, but it's not like it gets written very often. With that change, I think this PR looks good.

Copy link
Contributor

@tschatzl tschatzl Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that.

Copy link

@kimbarrett kimbarrett left a comment

Looks good after discussed function name change.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270282: Semantically rename reference processing subphases

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 07e9052: 8270056: Generated lambda class can not access protected static method of target class
  • afe957c: 8268698: Use Objects.check{Index,FromToIndex,FromIndexSize} for java.base
  • a4e5f08: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump
  • 353e9c8: 8270320: JDK-8270110 committed invalid copyright headers
  • 7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking
  • 41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
  • 548bb31: 8270110: Shenandoah: Add test for JDK-8269661
  • c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/86a20081aefb6d43dc8a4d404adb2c1fb5729585...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 12, 2021
Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm apart from that naming issue.

@@ -80,7 +80,7 @@ class ReferenceProcessorPhaseTimes : public CHeapObj<mtGC> {
ReferenceProcessorPhaseTimes(GCTimer* gc_timer, uint max_gc_threads);
~ReferenceProcessorPhaseTimes();

WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }
Copy link
Contributor

@tschatzl tschatzl Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that.

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Jul 13, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit 565ec85.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 07e9052: 8270056: Generated lambda class can not access protected static method of target class
  • afe957c: 8268698: Use Objects.check{Index,FromToIndex,FromIndexSize} for java.base
  • a4e5f08: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump
  • 353e9c8: 8270320: JDK-8270110 committed invalid copyright headers
  • 7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking
  • 41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
  • 548bb31: 8270110: Shenandoah: Add test for JDK-8269661
  • c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/86a20081aefb6d43dc8a4d404adb2c1fb5729585...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@albertnetymk Pushed as commit 565ec85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the phase1-rename branch Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants