Skip to content

8270282: Semantically rename reference processing subphases #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8270282: Semantically rename reference processing subphases #4752

wants to merge 2 commits into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 12, 2021 •
edited by openjdk bot
Loading

Simple rename of phase{2,3,4} to something with semantic meaning.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270282: Semantically rename reference processing subphases

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4752/head:pull/4752
$ git checkout pull/4752

Update a local copy of the PR:
$ git checkout pull/4752
$ git pull https://git.openjdk.java.net/jdk pull/4752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4752

View PR using the GUI difftool:
$ git pr show -t 4752

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4752.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 12, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2021 •
edited
Loading

Webrevs

kimbarrett
kimbarrett reviewed Jul 12, 2021
View reviewed changes
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, except for a naming choice.

src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp Outdated
~ReferenceProcessorPhaseTimes();

WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }
Copy link

@kimbarrett kimbarrett Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird function name. I understand why, but I'm not convinced. We have process_soft_weak_final_refs and the like, for example.

Copy link
Member Author

@albertnetymk albertnetymk Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about soft_weak_final_refs_phase_worker_time_sec()?

Copy link

@kimbarrett kimbarrett Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's normal style. It's quite a mouthful, but it's not like it gets written very often. With that change, I think this PR looks good.

Copy link
Contributor

@tschatzl tschatzl Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that.

kimbarrett
kimbarrett approved these changes Jul 12, 2021
View reviewed changes
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after discussed function name change.

@openjdk
Copy link

openjdk bot commented Jul 12, 2021 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270282: Semantically rename reference processing subphases

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2021
tschatzl
tschatzl approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm apart from that naming issue.

src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp Outdated
~ReferenceProcessorPhaseTimes();

WorkerDataArray<double>* phase2_worker_time_sec() const { return _phase2_worker_time_sec; }
WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }
Copy link
Contributor

@tschatzl tschatzl Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that.

@albertnetymk
Copy link
Member Author

albertnetymk commented Jul 13, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2021

Going to push as commit 565ec85.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2021
@openjdk
Copy link

openjdk bot commented Jul 13, 2021

@albertnetymk Pushed as commit 565ec85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the phase1-rename branch July 13, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tschatzl tschatzl tschatzl approved these changes

@kimbarrett kimbarrett kimbarrett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albertnetymk @tschatzl @kimbarrett