Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270117: Broken jtreg link in "Building the JDK" page #4754

Closed
wants to merge 2 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Jul 12, 2021

Paraphrased description from the bug report:

The "Building the JDK" page has a jtreg download link pointing to https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/lastSuccessfulBuild/artifact but that gets a 404. I believe the correct link is https://ci.adoptopenjdk.net/view/work-in-progress/job/GetNode/lastSuccessfulBuild/artifact/ , which is not all that easy to find.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270117: Broken jtreg link in "Building the JDK" page

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4754/head:pull/4754
$ git checkout pull/4754

Update a local copy of the PR:
$ git checkout pull/4754
$ git pull https://git.openjdk.java.net/jdk pull/4754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4754

View PR using the GUI difftool:
$ git pr show -t 4754

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4754.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jul 12, 2021
@magicus
Copy link
Member Author

magicus commented Jul 12, 2021

/integrate auto

@openjdk openjdk bot added the auto label Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@magicus This pull request will be automatically integrated when it is ready

@mlbridge
Copy link

mlbridge bot commented Jul 12, 2021

Webrevs

doc/building.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270117: Broken jtreg link in "Building the JDK" page

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

/integrate

2 similar comments
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

Going to push as commit 41a5eb4.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@openjdk[bot] Pushed as commit 41a5eb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@openjdk[bot] The command integrate can only be used in open pull requests.

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@openjdk[bot] The command integrate can only be used in open pull requests.

@magicus magicus deleted the 8270117-broken-jtreg-link branch October 7, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto build build-dev@openjdk.org integrated Pull request has been integrated
2 participants