Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8264419: Remove has_max_index argument from G1BlockOffsetTablePart::block_at_or_preceding #4755

Closed
wants to merge 5 commits into from

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Jul 12, 2021

Please review this small change to remove superfluous function arguments.

Testing: tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264419: Remove has_max_index argument from G1BlockOffsetTablePart::block_at_or_preceding

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4755/head:pull/4755
$ git checkout pull/4755

Update a local copy of the PR:
$ git checkout pull/4755
$ git pull https://git.openjdk.java.net/jdk pull/4755/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4755

View PR using the GUI difftool:
$ git pr show -t 4755

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4755.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264419: Remove has_max_index argument from G1BlockOffsetTablePart::block_at_or_preceding

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 07e9052: 8270056: Generated lambda class can not access protected static method of target class
  • afe957c: 8268698: Use Objects.check{Index,FromToIndex,FromIndexSize} for java.base
  • a4e5f08: 8267281: Call prepare_for_dynamic_dumping for jcmd dynamic_dump
  • 353e9c8: 8270320: JDK-8270110 committed invalid copyright headers
  • 7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking
  • 41a5eb4: 8270117: Broken jtreg link in "Building the JDK" page
  • 1aef372: 8266578: Disambiguate BigDecimal description of scale
  • 92ae6a5: 8244162: Additional opportunities to use NONCOPYABLE
  • 548bb31: 8270110: Shenandoah: Add test for JDK-8269661
  • c3a42ed: 8269878: Handle redundant reg-2-reg moves in X86 backend

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

⚠️ @walulyai This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@walulyai
Copy link
Member Author

@walulyai walulyai commented Jul 14, 2021

Thanks @albertnetymk and @tschatzl for the reviews

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

Going to push as commit b6d7653.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 4a7ccf3: Merge
  • 8583aab: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
  • d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • b2416b6: 8269281: java/foreign/Test{Down,Up}call.java time out
  • bd95c0c: 8269635: Stress test SEGV while emitting OldObjectSample
  • 00ef65f: 8269525: Deadlock during Volano with JFR
  • e631add: 8259848: Interim javadoc build does not support platform links
  • 040c02b: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • 0f32982: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot
  • 770e2aa: 8215948: [TESTBUG] gtest pseudo-JavaThreads could be more regular JavaThreads
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/7cbb67a3f8adc83a5b51c092a66480d7b22a6bea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

@walulyai Pushed as commit b6d7653.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants