Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270320: JDK-8270110 committed invalid copyright headers #4757

Closed

Conversation

magicus
Copy link
Member

@magicus magicus commented Jul 12, 2021

The fix for JDK-8270110 added two new files with copyright headers that do not follow the prescribed format.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270320: JDK-8270110 committed invalid copyright headers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4757/head:pull/4757
$ git checkout pull/4757

Update a local copy of the PR:
$ git checkout pull/4757
$ git pull https://git.openjdk.java.net/jdk pull/4757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4757

View PR using the GUI difftool:
$ git pr show -t 4757

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4757.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@magicus
Copy link
Member Author

@magicus magicus commented Jul 12, 2021

/integrate auto

@openjdk openjdk bot added rfr auto labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@magicus This pull request will be automatically integrated when it is ready

@magicus
Copy link
Member Author

@magicus magicus commented Jul 12, 2021

/label add hotspot-gc shenandoah

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@magicus The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@magicus The hotspot-gc label was already applied.
The shenandoah label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270320: JDK-8270110 committed invalid copyright headers

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

/integrate

1 similar comment
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

Going to push as commit 353e9c8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7d2825e: 8270169: G1: Incorrect reference discovery MT degree in concurrent marking

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@openjdk[bot] Pushed as commit 353e9c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@openjdk[bot] The command integrate can only be used in open pull requests.

@magicus magicus deleted the 8270320-fix-copyright-headers branch Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-gc integrated shenandoah
2 participants