Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values #4758

Closed
wants to merge 2 commits into from

Conversation

@bplb
Copy link
Member

@bplb bplb commented Jul 12, 2021

Please consider this proposal to add some test coverage comparing Math and StrictMath results of pow().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4758/head:pull/4758
$ git checkout pull/4758

Update a local copy of the PR:
$ git checkout pull/4758
$ git pull https://git.openjdk.java.net/jdk pull/4758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4758

View PR using the GUI difftool:
$ git pr show -t 4758

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4758.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Loading

test/jdk/java/lang/Math/PowTests.java Outdated Show resolved Hide resolved
Loading
test/jdk/java/lang/Math/PowTests.java Outdated Show resolved Hide resolved
Loading
@bplb
Copy link
Member Author

@bplb bplb commented Jul 22, 2021

Ping.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 242 new commits pushed to the master branch:

  • 984003d: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
  • c1c4048: 8249634: doclint should report implicit constructor as missing javadoc comments
  • 09e5321: 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage
  • 258f188: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package
  • 3cadc36: 8270336: [TESTBUG] Fix initialization in NonbranchyTree
  • c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
  • 8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
  • d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
  • 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
  • 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
  • ... and 232 more: https://git.openjdk.java.net/jdk/compare/cb795893be8e6dcf725d8022aca16f657d3cc03c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 22, 2021
@bplb
Copy link
Member Author

@bplb bplb commented Jul 22, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 1362e09.
Since your change was applied there have been 242 commits pushed to the master branch:

  • 984003d: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
  • c1c4048: 8249634: doclint should report implicit constructor as missing javadoc comments
  • 09e5321: 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage
  • 258f188: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package
  • 3cadc36: 8270336: [TESTBUG] Fix initialization in NonbranchyTree
  • c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
  • 8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
  • d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
  • 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
  • 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
  • ... and 232 more: https://git.openjdk.java.net/jdk/compare/cb795893be8e6dcf725d8022aca16f657d3cc03c...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@bplb Pushed as commit 1362e09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@bplb bplb deleted the Math-PowTests-8211002 branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants