Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263531: Remove unused buffer int #4759

Closed
wants to merge 1 commit into from
Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 12, 2021

The change for JDK-8257001 left an obsolete int field. Remove it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4759/head:pull/4759
$ git checkout pull/4759

Update a local copy of the PR:
$ git checkout pull/4759
$ git pull https://git.openjdk.java.net/jdk pull/4759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4759

View PR using the GUI difftool:
$ git pr show -t 4759

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4759.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@RealCLanger The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263531: Remove unused buffer int

Reviewed-by: chegar, vtewari, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 7ac0816: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
  • 460c4bb: 8270179: Rename Amalloc_4
  • 375fc2a: 8270009: Factor out and shuffle methods in G1CollectedHeap::do_collection_pause_at_safepoint_helper
  • 6b123b0: Merge
  • 4fc3180: 8266345: (fs) Custom DefaultFileSystemProvider security related loops
  • 999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • 3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
  • 2546006: 8270216: [macOS] Update named used for Java run loop mode
  • 565ec85: 8270282: Semantically rename reference processing subphases
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 13, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit ca806ef.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 7ac0816: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
  • 460c4bb: 8270179: Rename Amalloc_4
  • 375fc2a: 8270009: Factor out and shuffle methods in G1CollectedHeap::do_collection_pause_at_safepoint_helper
  • 6b123b0: Merge
  • 4fc3180: 8266345: (fs) Custom DefaultFileSystemProvider security related loops
  • 999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • 3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
  • 2546006: 8270216: [macOS] Update named used for Java run loop mode
  • 565ec85: 8270282: Semantically rename reference processing subphases
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@RealCLanger Pushed as commit ca806ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8263531 branch Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
4 participants