Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270336: [TESTBUG] Fix initialization in NonbranchyTree #4761

Closed
wants to merge 3 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jul 13, 2021

The nsk.share.gc.NonbranchyTree might call initTree() twice and incorrectly reports branchiness in the case of IllegalArgumentException(...).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270336: [TESTBUG] Fix initialization in NonbranchyTree

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4761/head:pull/4761
$ git checkout pull/4761

Update a local copy of the PR:
$ git checkout pull/4761
$ git pull https://git.openjdk.java.net/jdk pull/4761/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4761

View PR using the GUI difftool:
$ git pr show -t 4761

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4761.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

One trivial grammar fix for a pre-existing problem in an error message. Otherwise looks good.

+ numberOfNodes + ", must be at "
+ "greater than 0 and less than "
+ " 1.");
+ branchiness + ", must be at greater than 0 and less than 1.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/be at/b/

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270336: [TESTBUG] Fix initialization in NonbranchyTree

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2021
Copy link
Contributor

@tschatzl tschatzl left a comment

Looks good.

There is some typo in other code: s/Initizlize/Initialize. I do not need a re-review for that fix.

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Jul 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 3cadc36.
Since your change was applied there have been 48 commits pushed to the master branch:

  • c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
  • 8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
  • d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
  • 50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
  • 9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
  • 6096dd9: 8268893: jcmd to trim the glibc heap
  • c36755d: Merge
  • 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
  • e1051ae: 8264066: Enhance compiler validation
  • add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/f64436544156052fffb220e993a420f3f56b9b7c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@lmesnik Pushed as commit 3cadc36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8270336 branch Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants