8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

[azuev-java]

Make fallback code for inaccessible file to return multiresolution icon
Remove test from ProblemList

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4777/head:pull/4777
$ git checkout pull/4777

Update a local copy of the PR:
$ git checkout pull/4777
$ git pull https://git.openjdk.java.net/jdk pull/4777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4777

View PR using the GUI difftool:
$ git pr show -t 4777

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4777.diff

[bridgekeeper]

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azuev-java The following labels will be automatically applied to this pull request:

• 2d
• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (60978506)

[aivanov-jdk]

So, essentially all the icons returned are MultiResolutionIcon even if there's only one icon, right?

[azuev-java]

So, essentially all the icons returned are MultiResolutionIcon even if there's only one icon, right?

It was a multiresolution icon even with one icon inside but only when the native and requested icon resolutions do not match. Now it will always be MRI even if file is inaccessible and there is a default icon in System32.dll that matches the requested resolution.

[openjdk]

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• c0d4eff: 6506405: Math.abs(float) is slow
• 357fe09: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")
• 589a1d5: 8270155: ARM32: Improve register dump in hs_err
• b6d7653: 8264419: Remove has_max_index argument from G1BlockOffsetTablePart::block_at_or_preceding
• 4a7ccf3: Merge
• 8583aab: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
• d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
• b2416b6: 8269281: java/foreign/Test{Down,Up}call.java time out
• bd95c0c: 8269635: Stress test SEGV while emitting OldObjectSample
• 00ef65f: 8269525: Deadlock during Volano with JFR
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azuev-java]

/integrate

[openjdk]

Going to push as commit a033866.
Since your change was applied there have been 31 commits pushed to the master branch:

• 14da658: 8270453: [JVMCI] remove duplicates in vmStructs_jvmci.cpp
• fb86d13: 8270100: Fix some inaccurate GC logging
• b1bb05b: 8269592: [JVMCI] Optimize c2v_iterateFrames
• c0d4eff: 6506405: Math.abs(float) is slow
• 357fe09: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")
• 589a1d5: 8270155: ARM32: Improve register dump in hs_err
• b6d7653: 8264419: Remove has_max_index argument from G1BlockOffsetTablePart::block_at_or_preceding
• 4a7ccf3: Merge
• 8583aab: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
• d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azuev-java Pushed as commit a033866.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.