New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows #4777
Conversation
…fails on windows Make fallback code for inaccessible file to return multiresolution icon Remove test from ProblemList
|
@azuev-java The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
So, essentially all the icons returned are MultiResolutionIcon even if there's only one icon, right? |
It was a multiresolution icon even with one icon inside but only when the native and requested icon resolutions do not match. Now it will always be MRI even if file is inaccessible and there is a default icon in System32.dll that matches the requested resolution. |
@azuev-java This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit a033866.
Your commit was automatically rebased without conflicts. |
@azuev-java Pushed as commit a033866. |
Make fallback code for inaccessible file to return multiresolution icon
Remove test from ProblemList
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4777/head:pull/4777
$ git checkout pull/4777
Update a local copy of the PR:
$ git checkout pull/4777
$ git pull https://git.openjdk.java.net/jdk pull/4777/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4777
View PR using the GUI difftool:
$ git pr show -t 4777
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4777.diff