New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270453: [JVMCI] remove duplicates in vmStructs_jvmci.cpp #4779
Conversation
@@ -496,13 +496,6 @@ | |||
declare_constant(vmIntrinsics::_invokeGeneric) \ | |||
declare_constant(vmIntrinsics::_compiledLambdaForm) \ | |||
\ | |||
declare_constant(CollectedHeap::Serial) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated declarations start on line 487.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial.
Duplicates were added by
8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
@dougxc This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks for the review @vnkozlov . |
/integrate |
Going to push as commit 14da658.
Your commit was automatically rebased without conflicts. |
Removes some duplicate exports in vmStructs_jvmci.cpp.
I've tested by comparing the output of
java -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+EagerJVMCI -Djvmci.PrintConfig=true -version
before and after this change.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4779/head:pull/4779
$ git checkout pull/4779
Update a local copy of the PR:
$ git checkout pull/4779
$ git pull https://git.openjdk.java.net/jdk pull/4779/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4779
View PR using the GUI difftool:
$ git pr show -t 4779
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4779.diff