Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8270468: TestRangeCheckEliminated fails because methods are not compiled #4781

Closed

Conversation

mychris
Copy link
Contributor

@mychris mychris commented Jul 14, 2021

Hi,

please review this small change to the TestRangeCheckEliminated test case, which ensures that the required methods are compiled on every platform, by setting the CompileThreshold explicitly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270468: TestRangeCheckEliminated fails because methods are not compiled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4781/head:pull/4781
$ git checkout pull/4781

Update a local copy of the PR:
$ git checkout pull/4781
$ git pull https://git.openjdk.java.net/jdk pull/4781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4781

View PR using the GUI difftool:
$ git pr show -t 4781

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4781.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2021
@openjdk
Copy link

openjdk bot commented Jul 14, 2021

@mychris The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 14, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented Jul 14, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270468: TestRangeCheckEliminated fails because methods are not compiled

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 99d7f9a: 8264908: Investigate adding BOT range check in G1BlockOffsetTablePart::block_at_or_preceding
  • e92e2fd: 8270517: Add Zero support for LoongArch
  • 7a89ffe: 8270014: Add scoped objects for g1 young gc verification and young gc internal timing
  • 793d772: 8270475: Remove unused G1STWDrainQueueClosure
  • 1ebd946: 8270333: -XX:+VerifyStringTableAtExit should not do linear search
  • 04b73bc: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 7c23491: 8269598: Regressions up to 5% on aarch64 seems due to JDK-8268858
  • 7d0edb5: Merge
  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/357fe09f2e46efa3343f6c8a57b8693dcd5dd43c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2021
@mychris
Copy link
Contributor Author

mychris commented Jul 15, 2021

Thanks for the reviews.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@mychris
Your change (at version d97bc1e) is now ready to be sponsored by a Committer.

@vnkozlov
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 15, 2021

Going to push as commit bb82005.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 057992f: 8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers
  • 746fe5d: 8270366: C2: Add associative rule to add/sub node
  • 1f995e5: 8265888: StandardJavaFileManager::setLocationForModule specification misses 'Implementation Requirements:'
  • c962e6e: 8261006: 'super' qualified method references cannot occur in a static context
  • 99d7f9a: 8264908: Investigate adding BOT range check in G1BlockOffsetTablePart::block_at_or_preceding
  • e92e2fd: 8270517: Add Zero support for LoongArch
  • 7a89ffe: 8270014: Add scoped objects for g1 young gc verification and young gc internal timing
  • 793d772: 8270475: Remove unused G1STWDrainQueueClosure
  • 1ebd946: 8270333: -XX:+VerifyStringTableAtExit should not do linear search
  • 04b73bc: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/357fe09f2e46efa3343f6c8a57b8693dcd5dd43c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@vnkozlov @mychris Pushed as commit bb82005.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants