Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8265888: StandardJavaFileManager::setLocationForModule specification misses 'Implementation Requirements:' #4785

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jul 14, 2021

Please review a simple no-reg doc fix to add an @implSpec to StandardJavaFileManager::setLocationForModule.

The change is as for the CSR. There is no functional change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265888: StandardJavaFileManager::setLocationForModule specification misses 'Implementation Requirements:'

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4785/head:pull/4785
$ git checkout pull/4785

Update a local copy of the PR:
$ git checkout pull/4785
$ git pull https://git.openjdk.java.net/jdk pull/4785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4785

View PR using the GUI difftool:
$ git pr show -t 4785

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4785.diff

@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented Jul 14, 2021

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr csr labels Jul 14, 2021
@openjdk
Copy link

openjdk bot commented Jul 14, 2021

@jonathan-gibbons this pull request will not be integrated until the CSR request JDK-8270437 for issue JDK-8265888 has been approved.

@openjdk
Copy link

openjdk bot commented Jul 14, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Jul 14, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2021

Webrevs

@openjdk openjdk bot removed the csr label Jul 14, 2021
Copy link
Contributor

@lahodaj lahodaj left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265888: StandardJavaFileManager::setLocationForModule specification misses 'Implementation Requirements:'

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 1ebd946: 8270333: -XX:+VerifyStringTableAtExit should not do linear search
  • 04b73bc: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 7c23491: 8269598: Regressions up to 5% on aarch64 seems due to JDK-8268858
  • 7d0edb5: Merge
  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • 3bbd233: 8270075: SplittableRandom extends AbstractSplittableGenerator
  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/4a7ccf36e9a3978c437db3efe892dd23e8a0b772...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 15, 2021
@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented Jul 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2021

Going to push as commit 1f995e5.
Since your change was applied there have been 25 commits pushed to the master branch:

  • c962e6e: 8261006: 'super' qualified method references cannot occur in a static context
  • 99d7f9a: 8264908: Investigate adding BOT range check in G1BlockOffsetTablePart::block_at_or_preceding
  • e92e2fd: 8270517: Add Zero support for LoongArch
  • 7a89ffe: 8270014: Add scoped objects for g1 young gc verification and young gc internal timing
  • 793d772: 8270475: Remove unused G1STWDrainQueueClosure
  • 1ebd946: 8270333: -XX:+VerifyStringTableAtExit should not do linear search
  • 04b73bc: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 7c23491: 8269598: Regressions up to 5% on aarch64 seems due to JDK-8268858
  • 7d0edb5: Merge
  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/4a7ccf36e9a3978c437db3efe892dd23e8a0b772...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@jonathan-gibbons Pushed as commit 1f995e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8265888.setLocationForModule branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
2 participants