Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API #4789

Closed
wants to merge 3 commits into from

Conversation

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jul 15, 2021

This is a cleanup fix that replaces the deprecated method Class::newInstance() with cls.getDeclaredConstructor().newInstance() when loading the provider.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4789/head:pull/4789
$ git checkout pull/4789

Update a local copy of the PR:
$ git checkout pull/4789
$ git pull https://git.openjdk.java.net/jdk pull/4789/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4789

View PR using the GUI difftool:
$ git pr show -t 4789

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4789.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 15, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 15, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the net label Jul 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 15, 2021

Webrevs

Loading

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

The changes mostly look good. I have just a few small comments on the test.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API

Reviewed-by: chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • cd8783c: 8270820: remove unused stiFileTableIndex from SDE.c
  • 1f51e13: 8270147: Increase stride size allowing unrolling more loops
  • 7dd19af: 8270803: Reduce CDS API verbosity
  • 6346793: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • 1eeb179: Merge
  • 61359c4: 8270993: Missing forward declaration of ZeroFrame
  • 8e8e87a: 8268223: Problemlist vmTestbase/nsk/jdi/HiddenClass/events/events001.java
  • 845c31d: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC
  • 0cec11d: 8270307: C2: assert(false) failed: bad AD file after JDK-8267687
  • 38694aa: 8270939: ProblemList java/lang/invoke/RicochetTest.java until JDK-8251969 is fixed
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/357fe09f2e46efa3343f6c8a57b8693dcd5dd43c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 21, 2021
@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Jul 22, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 50bb731.
Since your change was applied there have been 91 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@FrauBoes Pushed as commit 50bb731.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants