Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test #4791

Closed
wants to merge 1 commit into from

Conversation

fguallini
Copy link
Member

@fguallini fguallini commented Jul 15, 2021

This change converts security/JavaDotSecurity/ifdefs.sh to java equivalent


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4791/head:pull/4791
$ git checkout pull/4791

Update a local copy of the PR:
$ git checkout pull/4791
$ git pull https://git.openjdk.java.net/jdk pull/4791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4791

View PR using the GUI difftool:
$ git pr show -t 4791

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4791.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2021

Webrevs

@fguallini
Copy link
Member Author

Please if someone could review and sponsor this PR. Thanks!

@openjdk
Copy link

openjdk bot commented Jul 21, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 194 new commits pushed to the master branch:

  • 515113d: 8269924: Shenandoah: Introduce weak/strong marking asserts
  • f2c359a: 8271215: Fix data races in G1PeriodicGCTask
  • 36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • e4295cc: 8270519: Move several vector helper methods to shared header file
  • e627cae: 8270317: Large Allocation in CipherSuite
  • 0dcfc42: Merge
  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • 7468bbc: 8266988: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
  • ... and 184 more: https://git.openjdk.java.net/jdk/compare/3d193adbec07a77dce3b34fe5d0dbb99ff03b9a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2021
@fguallini
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 26, 2021
@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@fguallini
Your change (at version 1a5ede9) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

rhalade commented Jul 28, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

Going to push as commit 9711033.
Since your change was applied there have been 229 commits pushed to the master branch:

  • 60c11fe: 8261088: Repeatable annotations without @target cannot have containers that target module declarations
  • dcdb1b6: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • ... and 219 more: https://git.openjdk.java.net/jdk/compare/3d193adbec07a77dce3b34fe5d0dbb99ff03b9a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@rhalade @fguallini Pushed as commit 9711033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants