Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270540 G1: Refactor range checking in G1BlockOffsetTablePart::block_start* to asserts #4794

Closed

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Jul 15, 2021

Hi all,

Please review this clean-up to replace range checking with asserts.

Testing: tier 1-3


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270540: G1: Refactor range checking in G1BlockOffsetTablePart::block_start* to asserts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4794/head:pull/4794
$ git checkout pull/4794

Update a local copy of the PR:
$ git checkout pull/4794
$ git pull https://git.openjdk.java.net/jdk pull/4794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4794

View PR using the GUI difftool:
$ git pr show -t 4794

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4794.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 15, 2021

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 15, 2021

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 15, 2021

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270540: G1: Refactor range checking in G1BlockOffsetTablePart::block_start* to asserts

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 15, 2021
@walulyai
Copy link
Member Author

@walulyai walulyai commented Jul 16, 2021

Thanks @albertnetymk and @tschatzl for your reviews

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

Going to push as commit 1d8d72d.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

@walulyai Pushed as commit 1d8d72d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants