8270797: ShortECDSA.java test is not complete

[wangweij]

Add code to call XML signing using internal APIs. The implementation was also fixed back in JDK-8259535 but not covered by the new test there.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8270797: ShortECDSA.java test is not complete

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4800/head:pull/4800
$ git checkout pull/4800

Update a local copy of the PR:
$ git checkout pull/4800
$ git pull https://git.openjdk.java.net/jdk pull/4800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4800

View PR using the GUI difftool:
$ git pr show -t 4800

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4800.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[wangweij]

/label add security

[openjdk]

@wangweij
The security label was successfully added.

[mlbridge]

Webrevs

• 00: Full (303994c6)

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270797: ShortECDSA.java test is not complete

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 253 new commits pushed to the master branch:

• 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
• eec64f5: 8256844: Make NMT late-initializable
• 4df1bc4: 6350025: API documentation for JOptionPane using deprecated methods.
• efcdcc7: 8270893: IndexOutOfBoundsException while reading large TIFF file
• 977b8c4: 8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs
• 04134fc: 8264543: Cross modify fence optimization for x86
• 9e76909: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
• e49b7d9: 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags
• 68f7847: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
• 3d40cac: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
• ... and 243 more: https://git.openjdk.java.net/jdk/compare/357fe09f2e46efa3343f6c8a57b8693dcd5dd43c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit 221e4b9.
Since your change was applied there have been 253 commits pushed to the master branch:

• 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
• eec64f5: 8256844: Make NMT late-initializable
• 4df1bc4: 6350025: API documentation for JOptionPane using deprecated methods.
• efcdcc7: 8270893: IndexOutOfBoundsException while reading large TIFF file
• 977b8c4: 8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs
• 04134fc: 8264543: Cross modify fence optimization for x86
• 9e76909: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
• e49b7d9: 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags
• 68f7847: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
• 3d40cac: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
• ... and 243 more: https://git.openjdk.java.net/jdk/compare/357fe09f2e46efa3343f6c8a57b8693dcd5dd43c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 221e4b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.