Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests #4804

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jul 16, 2021

Two tests have started failing regularly in our CI testing, and also in GHA, so I'm ProblemListing them until the issue can be resolved.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4804/head:pull/4804
$ git checkout pull/4804

Update a local copy of the PR:
$ git checkout pull/4804
$ git pull https://git.openjdk.java.net/jdk pull/4804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4804

View PR using the GUI difftool:
$ git pr show -t 4804

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4804.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@dholmes-ora
Copy link
Member Author

/label add hotspot-serviceability

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@dholmes-ora The label hotspot-serviceability is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@dholmes-ora
Copy link
Member Author

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@dholmes-ora
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 16, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270814: ProblemList the failing serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor* tests

Reviewed-by: tschatzl, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 16, 2021
@NikolayTach
Copy link

NikolayTach commented Jul 16, 2021

It doesn't include a complete implementation of the Java SE 16 Platform and additional Java APIs to support developing, debugging, and monitoring Java applications. Another source of information about important enhancements and new features in Java SE 16 and JDK 16 is the Java SE 16 ( JSR 391) Platform Specification, which documents the changes to the specification made between Java SE 15 and Java SE 16. This document includes descriptions of those new features and enhancements that are also changes to the specification. The descriptions also identify potential compatibility issues that you might encounter when changing to JDK 16.

@dholmes-ora
Copy link
Member Author

Thanks for the reviews @tschatzl and @DamonFool !

/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

Going to push as commit 4927ee4.

@openjdk openjdk bot closed this Jul 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@dholmes-ora Pushed as commit 4927ee4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8270814 branch July 16, 2021 06:57
@NikolayTach
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants