Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8270820: remove unused stiFileTableIndex from SDE.c #4805

Closed
wants to merge 1 commit into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 16, 2021

Hello, please review this very small change. While checking compiler warnings of the type : "function 'xyz' was declared but never referenced" I came across stiFileTableIndex from SDE.c that generated such a warning and can be removed.

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270820: remove unused stiFileTableIndex from SDE.c

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4805/head:pull/4805
$ git checkout pull/4805

Update a local copy of the PR:
$ git checkout pull/4805
$ git pull https://git.openjdk.java.net/jdk pull/4805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4805

View PR using the GUI difftool:
$ git pr show -t 4805

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4805.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 16, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 16, 2021

Webrevs

@NikolayTach
Copy link

@NikolayTach NikolayTach commented Jul 16, 2021

Documents that changes to the specification made between Java SE 15 and Java SE 16.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270820: remove unused stiFileTableIndex from SDE.c

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 67dc1c5: 8270837: fix typos in test TestSigParse.java
  • 1d8d72d: 8270540: G1: Refactor range checking in G1BlockOffsetTablePart::block_start* to asserts
  • 90c219f: 8270547: java.util.Random contains unnecessary @SuppressWarnings("exports")

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 16, 2021
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jul 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

Going to push as commit cd8783c.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 1f51e13: 8270147: Increase stride size allowing unrolling more loops
  • 7dd19af: 8270803: Reduce CDS API verbosity
  • 6346793: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • 1eeb179: Merge
  • 61359c4: 8270993: Missing forward declaration of ZeroFrame
  • 8e8e87a: 8268223: Problemlist vmTestbase/nsk/jdi/HiddenClass/events/events001.java
  • 845c31d: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC
  • 0cec11d: 8270307: C2: assert(false) failed: bad AD file after JDK-8267687
  • 38694aa: 8270939: ProblemList java/lang/invoke/RicochetTest.java until JDK-8251969 is fixed
  • 754352f: 8270340: Base64 decodeBlock intrinsic for Power64 needs cleanup
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/4927ee426aedbeea0f4119bac0a342c6d3576762...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@MBaesken Pushed as commit cd8783c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants