Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270830: Aarch64: Use stp to initialize object on C1 #4808

Closed

Conversation

Wanghuang-Huawei
Copy link

@Wanghuang-Huawei Wanghuang-Huawei commented Jul 16, 2021

Here is a trivail patch on aarch64.
It is found that in C1_MacroAssembler::initialize_object which we can usestpto replace str.

@@ -250,13 +249,16 @@ void C1_MacroAssembler::initialize_object(Register obj, Register klass, Register
        for (int i = -unroll; i < 0; i++) {
          if (-i == remainder)
            bind(entry_point);
- str(zr, Address(rscratch1, i * wordSize));
+ stp(zr, zr, Address(rscratch1, i * 2 * BytesPerWord));

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270830: Aarch64: Use stp to initialize object on C1

Contributors

  • Wang Huang <whuang@openjdk.org>
  • Miao Zhuojun <mouzhuojun@huawei.com>
  • Wu Yan <wuyan@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4808/head:pull/4808
$ git checkout pull/4808

Update a local copy of the PR:
$ git checkout pull/4808
$ git pull https://git.openjdk.java.net/jdk pull/4808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4808

View PR using the GUI difftool:
$ git pr show -t 4808

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4808.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 16, 2021
@Wanghuang-Huawei
Copy link
Author

/contributor add Wang Huang whuang@openjdk.org
/contributor add Miu Zhuojun mouzhuojun@huawei.com

@mlbridge
Copy link

mlbridge bot commented Jul 16, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@Wanghuang-Huawei
Contributor Miu Zhuojun <mouzhuojun@huawei.com> successfully added.

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@Wanghuang-Huawei Could not parse Miu Zhuojun as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@Wanghuang-Huawei
Copy link
Author

/contributor add Miao Zhuojun mouzhuojun@huawei.com

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@Wanghuang-Huawei
Contributor Miao Zhuojun <mouzhuojun@huawei.com> successfully added.

@Wanghuang-Huawei
Copy link
Author

/contributor remove Miu Zhuojun mouzhuojun@huawei.com

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@Wanghuang-Huawei
Contributor Miu Zhuojun <mouzhuojun@huawei.com> successfully removed.

@nick-arm
Copy link
Contributor

How have you tested this?

@snazarkin
Copy link
Contributor

Should not unroll be adjusted after switching to double word write?

@Wanghuang-Huawei
Copy link
Author

/contributor add Wu Yan wuyan@openjdk.org

@openjdk
Copy link

openjdk bot commented Jul 20, 2021

@Wanghuang-Huawei
Contributor Wu Yan <wuyan@openjdk.org> successfully added.

@theRealAph
Copy link
Contributor

This C1 code is being rewritten to use the common MacroAssembler::zero words which was written for C2. It's shorter and faster and there's less code to maintain. It doesn't make any sense to change the C1 code at this time,

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2021

@Wanghuang-Huawei This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wuyan0
Copy link

wuyan0 commented Aug 24, 2021

Thanks for your reply, I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
5 participants