Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270837: fix typos in test TestSigParse.java #4812

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jul 16, 2021

Please review this trivial fix for JDK-8270837. The modified test was tested by running Mach5 tier1 on Linux, Mac OS, and Windows and by running the test locally on Linux x64.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4812/head:pull/4812
$ git checkout pull/4812

Update a local copy of the PR:
$ git checkout pull/4812
$ git pull https://git.openjdk.java.net/jdk pull/4812/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4812

View PR using the GUI difftool:
$ git pr show -t 4812

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4812.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 16, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.
Thanks.

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270837: fix typos in test TestSigParse.java

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 16, 2021
@hseigel
Copy link
Member Author

hseigel commented Jul 16, 2021

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2021

Going to push as commit 67dc1c5.

@openjdk openjdk bot closed this Jul 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

@hseigel Pushed as commit 67dc1c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@NikolayTach
Copy link

binary license

@kevinrushforth
Copy link
Member

@NikolayTach I see you have added comments to a few openjdk pull requests. None of them are relevant to the pull requests in question, so I presume that these comments were added in error. Please take the necessary steps to avoid adding irrelevant comments in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants