-
Notifications
You must be signed in to change notification settings - Fork 6k
8270837: fix typos in test TestSigParse.java #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Thanks.
@hseigel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! /integrate |
Going to push as commit 67dc1c5. |
@NikolayTach I see you have added comments to a few |
Please review this trivial fix for JDK-8270837. The modified test was tested by running Mach5 tier1 on Linux, Mac OS, and Windows and by running the test locally on Linux x64.
Thanks, Harold
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4812/head:pull/4812
$ git checkout pull/4812
Update a local copy of the PR:
$ git checkout pull/4812
$ git pull https://git.openjdk.java.net/jdk pull/4812/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4812
View PR using the GUI difftool:
$ git pr show -t 4812
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4812.diff