Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270869: G1ServiceThread may not terminate #4819

Closed
wants to merge 2 commits into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 18, 2021

Please review this fix of a rare race in G1ServiceThread termination that
can lead to the thread not terminating in a timely manner.

Testing:
mach5 tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4819/head:pull/4819
$ git checkout pull/4819

Update a local copy of the PR:
$ git checkout pull/4819
$ git pull https://git.openjdk.java.net/jdk pull/4819/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4819

View PR using the GUI difftool:
$ git pr show -t 4819

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4819.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 18, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 18, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jul 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 18, 2021

Webrevs

Loading

Copy link
Member

@albertnetymk albertnetymk left a comment

Only a minor comment on the style; I think not using else-if is clearer: the early-return handles the exiting condition, and the other two cases depend on the task queue state.

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Looks good, same comment about the use of the else if, but I'm good either way.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270869: G1ServiceThread may not terminate

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 19, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 19, 2021

Looks good, same comment about the use of the else if, but I'm good either way.

I think that looks weird; the if-ladder covers all cases, and splitting it up makes that seem less obvious to me. Also, if I were to split it up I would probably write the exiting case as
if (should_terminate()) return;
which I know Thomas has a preference against.

Aside: I think this function might get rewritten as part of what I'm thinking about doing under JDK-8270870, which will probably render this discussion moot.

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Jul 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

Going to push as commit 7f35e5b.

Loading

@openjdk openjdk bot closed this Jul 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@kimbarrett Pushed as commit 7f35e5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kimbarrett kimbarrett deleted the g1service_terminate branch Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants