Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270519: Move several vector helper methods to shared header file #4822

Closed
wants to merge 1 commit into from

Conversation

@XiaohongGong
Copy link
Contributor

@XiaohongGong XiaohongGong commented Jul 19, 2021

Hi, could anyone please take a look at this simple patch?

This is a followed-up patch to [1] which added several arch independent vector methods (e.g. vector_length/vector_element_basic_type). Since these methods also exist in x86.ad and are widely used in their match rules, it's better to move the shared methods to a common shared place.

[1] https://bugs.openjdk.java.net/browse/JDK-8269725

Tested tier1 and jdk:tier3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270519: Move several vector helper methods to shared header file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4822/head:pull/4822
$ git checkout pull/4822

Update a local copy of the PR:
$ git checkout pull/4822
$ git pull https://git.openjdk.java.net/jdk pull/4822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4822

View PR using the GUI difftool:
$ git pr show -t 4822

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4822.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back xgong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@XiaohongGong The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Looks reasonable to me.
Thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@XiaohongGong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270519: Move several vector helper methods to shared header file

Reviewed-by: jiefu, njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

  • e627cae: 8270317: Large Allocation in CipherSuite
  • 0dcfc42: Merge
  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • 7468bbc: 8266988: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
  • 286106d: 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass
  • a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
  • 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ec71e2d: 8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass
  • ... and 96 more: https://git.openjdk.java.net/jdk/compare/e35005d5ce383ddd108096a3079b17cb0bcf76f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool, @nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 19, 2021
@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Jul 21, 2021

Hi @theRealAph , could you please take a look at this patch especially the AArch64 part? Thanks so much!

@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Jul 22, 2021

Thanks for the review @DamonFool !

nsjian
nsjian approved these changes Jul 22, 2021
@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Jul 22, 2021

Thanks for the review @nsjian !

@XiaohongGong
Copy link
Contributor Author

@XiaohongGong XiaohongGong commented Jul 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@XiaohongGong
Your change (at version 8447554) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jul 26, 2021

See no objection, so sponsor it.
/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

Going to push as commit e4295cc.
Since your change was applied there have been 106 commits pushed to the master branch:

  • e627cae: 8270317: Large Allocation in CipherSuite
  • 0dcfc42: Merge
  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • 7468bbc: 8266988: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
  • 286106d: 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass
  • a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
  • 4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ec71e2d: 8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass
  • ... and 96 more: https://git.openjdk.java.net/jdk/compare/e35005d5ce383ddd108096a3079b17cb0bcf76f1...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@DamonFool @XiaohongGong Pushed as commit e4295cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XiaohongGong XiaohongGong deleted the JDK-8270519 branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants