Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails #4823

Closed
wants to merge 2 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jul 19, 2021

This test fails to follow the test instruction which says ""On Top" print dialogs should stay behind the "Owner Window"
but it seems to be the behaviour right from jdk11b18 where DialogOwner class and this test was inducted via JDK-8203796 not only in mac but in windows too ie,
"On Top" print dialogs should stay behind the "Owner Window" as per instruction but is not.
On Top print dialogs actually stay above the "owner window"

I guess there is some ambiguity in test instruction or clarity in understanding test instructions is not there
because Test instructions says "For On Top tests all windows should stay behind the owner window."
but "Owner Window" instruction says "For tests that are 'Owned' or 'On Top' the dialog must always stay above this window. "

Rectified the test instruction to be same as owner window instruction


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4823/head:pull/4823
$ git checkout pull/4823

Update a local copy of the PR:
$ git checkout pull/4823
$ git pull https://git.openjdk.java.net/jdk pull/4823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4823

View PR using the GUI difftool:
$ git pr show -t 4823

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4823.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Jul 19, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jul 19, 2021

/label remove awt

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jul 19, 2021

/label add 2d

@openjdk openjdk bot removed the awt label Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@prsadhuk
The awt label was successfully removed.

@openjdk openjdk bot added the 2d label Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@prsadhuk
The 2d label was successfully added.

@prsadhuk prsadhuk changed the title [macos] java/awt/print/Dialog/DialogOwnerTest.java fails 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails Jul 19, 2021
@openjdk openjdk bot added the rfr label Jul 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails

Reviewed-by: azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 596 new commits pushed to the master branch:

  • 0790f04: 8271015: Split cds/SharedBaseAddress.java test into smaller parts
  • 024c402: 8271014: Refactor HeapShared::is_archived_object()
  • ddce47c: 8270949: Make dynamically generated classes with the class file version of the current release
  • b7245c6: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 57611b3: 8270991: G1 Full GC always performs heap verification after JDK-8269295
  • cd8783c: 8270820: remove unused stiFileTableIndex from SDE.c
  • 1f51e13: 8270147: Increase stride size allowing unrolling more loops
  • 7dd19af: 8270803: Reduce CDS API verbosity
  • 6346793: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • 1eeb179: Merge
  • ... and 586 more: https://git.openjdk.java.net/jdk/compare/f40c89e8e9fae26da53b5d820d8e64d9b30faf8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 21, 2021
prrace
prrace approved these changes Jul 21, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jul 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 9131a8f.
Since your change was applied there have been 617 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@prsadhuk Pushed as commit 9131a8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8267940 branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants