Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8205138: Remove Applet references from Font2DTest #4831

Closed
wants to merge 3 commits into from
Closed

8205138: Remove Applet references from Font2DTest #4831

wants to merge 3 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jul 19, 2021

Applet support was removed already but the .html file was left as well as docs on applet issues
and a parameter only relevant to applets.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8205138: Remove Applet references from Font2DTest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4831/head:pull/4831
$ git checkout pull/4831

Update a local copy of the PR:
$ git checkout pull/4831
$ git pull https://git.openjdk.java.net/jdk pull/4831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4831

View PR using the GUI difftool:
$ git pr show -t 4831

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4831.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2021
@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prrace
Copy link
Contributor Author

prrace commented Jul 20, 2021

/label 2d

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Jul 20, 2021
@openjdk
Copy link

openjdk bot commented Jul 20, 2021

@prrace
The 2d label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 20, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Jul 21, 2021

Probably we can delete the SwingSet2.html as well?

@@ -268,11 +268,6 @@ private void setupMenu( boolean isApplet ) {
fileMenu.add( new MenuItemV2( "Page Setup...", this ));
fileMenu.add( new MenuItemV2( "Print...", this ));
fileMenu.addSeparator();
if ( !isApplet )
fileMenu.add( new MenuItemV2( "Exit", this ));
Copy link
Contributor

@prsadhuk prsadhuk Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not Applet, should we not retain this line?

Copy link
Contributor Author

@prrace prrace Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsy. I did not mean to do that. I will restore.


- There are still some bugs around the error handling.
Most of these problems will usually get fixed when some parameters
are changed, or the screen is refreshed.
Copy link
Contributor

@prsadhuk prsadhuk Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the 1st 2 known problems are not there now?

Copy link
Contributor Author

@prrace prrace Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know of problems with getting metrics for Postscript fonts and I have no idea what the 2nd comment means and it may be ancient history which is why I want to clean it up.

@prrace
Copy link
Contributor Author

prrace commented Aug 12, 2021

Probably we can delete the SwingSet2.html as well?

Yes, there's a separate bug for that which I'll be getting around to.

mrserb
mrserb approved these changes Aug 12, 2021
@openjdk
Copy link

openjdk bot commented Aug 12, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8205138: Remove Applet references from Font2DTest

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

  • 4d4ba5c: 8272116: Update PerfDisableSharedMem with FLAG_SET_ERGO in PerfMemory::create_memory_region
  • 09ab86b: 8269909: getStack method in hprof.parser.Reader should use try-with-resource
  • e4766ee: 8272391: Undeleted debug information
  • 428d516: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 93cab7d: 8272315: Improve assert_different_registers
  • 9980b41: 8272107: Removal of Unsafe::defineAnonymousClass left a dangling C++ class
  • 464e874: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7e14c3c: 8272310: AArch64: Add missing changes for shared vector helper methods in m4 files
  • b29fbad: 8267844: Replace Integer/Long.valueOf() with Integer/Long.parse*() where applicable
  • d38b314: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/38ff85c824750e7da66fd86f5bde1c4587e529c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2021
@prrace
Copy link
Contributor Author

prrace commented Aug 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2021

Going to push as commit 0af645a.
Since your change was applied there have been 61 commits pushed to the master branch:

  • bd7f9b4: 8272459: ProblemList compiler/codecache/TestStressCodeBuffers.java on aarch64
  • 717792c: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
  • d06d0b9: 8272112: Arena code simplifications
  • 0c4be76: 8058704: Nimbus does not honor JTextPane background color
  • 020aec5: 8271366: [REDO] JDK-8266054 VectorAPI rotate operation optimization
  • 4d4ba5c: 8272116: Update PerfDisableSharedMem with FLAG_SET_ERGO in PerfMemory::create_memory_region
  • 09ab86b: 8269909: getStack method in hprof.parser.Reader should use try-with-resource
  • e4766ee: 8272391: Undeleted debug information
  • 428d516: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 93cab7d: 8272315: Improve assert_different_registers
  • ... and 51 more: https://git.openjdk.java.net/jdk/compare/38ff85c824750e7da66fd86f5bde1c4587e529c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2021
@openjdk
Copy link

openjdk bot commented Aug 13, 2021

@prrace Pushed as commit 0af645a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants