8269984: [macos] JTabbedPane title looks like disabled #4833
Conversation
Fixed verion analysis so it works correctly with new naming scheme of macOS 11.x and beyond
|
👋 Welcome back kizune! A progress list of the required criteria for merging this PR into |
|
@azuev-java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Is it the same bug as #4824 ? |
Looks like it but in my case it is fixed correctly. His fix will not work on macOS 12 or above, mine will. |
| @SuppressWarnings("removal") | ||
| String osVersion = AccessController.doPrivileged(new GetPropertyAction("os.version")); | ||
| String[] fragments = osVersion.split("\\."); | ||
|
|
||
| // sanity check the "10." part of the version | ||
| if (!fragments[0].equals("10")) return false; | ||
| if (fragments.length < 2) return false; |
There was a problem hiding this comment.
Will there always be 2 fragments now ? Does "12" get reported as "12.0" ?
There was a problem hiding this comment.
Will there always be 2 fragments now ? Does "12" get reported as "12.0" ?
As far as i know there always 3 - Apple always uses major.minor.patchLevel format - even when patch level is 0 they still include it. We only care about the first two though so as long as they are present we are Ok with it and even is Apple will move away from major.minor replacing it with just a major version there still will be a patch level so this code will still work.
I guess it is inevitable - as well as backporting it into the previous releases where original fix was integrated. Good thing is that this patch cleanly applies to jdk17 and i already tested it on BigSur with 17 and 16u so there will be less effort required. |
|
Closing this PR while opening one for jdk17. |
Fixed the version string parsing to work correctly on macOS 11.x and beyond
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4833/head:pull/4833$ git checkout pull/4833Update a local copy of the PR:
$ git checkout pull/4833$ git pull https://git.openjdk.java.net/jdk pull/4833/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4833View PR using the GUI difftool:
$ git pr show -t 4833Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4833.diff