-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test #484
Conversation
👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into |
@rhalade The issue |
@rhalade Setting summary to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Shouldn't we be seeing mach5 test failures from this though? I didn't see any failures.
@rhalade This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
We are still not beyond 90 days. It will start failing over the weekend. |
/integrate |
@rhalade Since your change was applied there have been 66 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 123e786. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk15u |
@rhalade Unknown command |
/help |
@rhalade Available commands:
|
/issue add 8239105
/summary "8239105: added verisigntsaca and thawtepremiumserverca to EXPIRY_EXC_ENTRIES list"
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/484/head:pull/484
$ git checkout pull/484