Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test #484

Closed
wants to merge 1 commit into from

Conversation

@rhalade
Copy link
Member

@rhalade rhalade commented Oct 2, 2020

/issue add 8239105
/summary "8239105: added verisigntsaca and thawtepremiumserverca to EXPIRY_EXC_ENTRIES list"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/484/head:pull/484
$ git checkout pull/484

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 2, 2020

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@rhalade The issue 8239105 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@rhalade Setting summary to "8239105: added verisigntsaca and thawtepremiumserverca to EXPIRY_EXC_ENTRIES list"

@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Oct 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 2, 2020

Webrevs

@rhalade rhalade changed the title 8239105: Add exception for expiring Digicert root certificates to Ver… Add exception for expiring Digicert root certificates to VerifyCACerts test Oct 2, 2020
@openjdk openjdk bot removed the rfr label Oct 2, 2020
@rhalade rhalade changed the title Add exception for expiring Digicert root certificates to VerifyCACerts test 8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test Oct 2, 2020
@openjdk openjdk bot added the rfr label Oct 2, 2020
Copy link
Member

@seanjmullan seanjmullan left a comment

Looks good. Shouldn't we be seeing mach5 test failures from this though? I didn't see any failures.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test

"8239105: added verisigntsaca and thawtepremiumserverca to EXPIRY_EXC_ENTRIES list"

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 2, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 2, 2020

Looks good. Shouldn't we be seeing mach5 test failures from this though? I didn't see any failures.

We are still not beyond 90 days. It will start failing over the weekend.

@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 2, 2020

/integrate

@openjdk openjdk bot closed this Oct 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2020

@rhalade Since your change was applied there have been 66 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 123e786.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the rhalade:JDK-8239105 branch Oct 6, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 1, 2020

/backport jdk15u

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2020

@rhalade Unknown command backport - for a list of valid commands use /help.

@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 1, 2020

/help

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2020

@rhalade Available commands:

  • covered - used when employer has signed the OCA
  • help - shows this text
  • signed - used after signing the OCA
  • test - used to run tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants