Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8270949: Make dynamically generated classes with the class file version of the current release #4840

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jul 20, 2021

Update classes spinned by java.lang.invoke and dynamic proxies to be of the class file version of the current release that will enable them to use the newest features when appropriate for example to support primitive classes in Valhalla repo.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270949: Make dynamically generated classes with the class file version of the current release

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4840/head:pull/4840
$ git checkout pull/4840

Update a local copy of the PR:
$ git checkout pull/4840
$ git pull https://git.openjdk.java.net/jdk pull/4840/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4840

View PR using the GUI difftool:
$ git pr show -t 4840

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4840.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jul 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270949: Make dynamically generated classes with the class file version of the current release

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 20, 2021
@mlchung
Copy link
Member Author

@mlchung mlchung commented Jul 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

Going to push as commit ddce47c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • b7245c6: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 57611b3: 8270991: G1 Full GC always performs heap verification after JDK-8269295
  • cd8783c: 8270820: remove unused stiFileTableIndex from SDE.c
  • 1f51e13: 8270147: Increase stride size allowing unrolling more loops
  • 7dd19af: 8270803: Reduce CDS API verbosity
  • 6346793: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • 1eeb179: Merge
  • 61359c4: 8270993: Missing forward declaration of ZeroFrame
  • 8e8e87a: 8268223: Problemlist vmTestbase/nsk/jdi/HiddenClass/events/events001.java
  • 845c31d: 8269240: java/foreign/stackwalk/TestAsyncStackWalk.java test failed with concurrent GC
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/38694aa970be73d269cb444ea80ebe7085bd9e90...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@mlchung Pushed as commit ddce47c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8270949 branch Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants