-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #4843
Conversation
…ption.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
Wrong bug number in the PR summary - should be 8269849.
@lmesnik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks, @kimbarrett. I've updated summary. |
/integrate |
Going to push as commit b7245c6.
Your commit was automatically rebased without conflicts. |
Test failed because caught OOME outside of
try{
...
}/catch( OutOfMemoryError e) {}
because of deoptimization even if no objects are allocated. The OOMStress is used to put the whole iteration into try/catch and ignore OOME.
I verified that test doesn't fail anymore and updated all similar tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4843/head:pull/4843
$ git checkout pull/4843
Update a local copy of the PR:
$ git checkout pull/4843
$ git pull https://git.openjdk.java.net/jdk pull/4843/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4843
View PR using the GUI difftool:
$ git pr show -t 4843
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4843.diff