8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

lmesnik · 2021-07-20T19:26:31Z

The small refactoring which consolidates shared code in the shared library. Make project more IDE-friendly.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package

Reviewers

Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 990bff2
Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4844/head:pull/4844
$ git checkout pull/4844

Update a local copy of the PR:
$ git checkout pull/4844
$ git pull https://git.openjdk.java.net/jdk pull/4844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4844

View PR using the GUI difftool:
$ git pr show -t 4844

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4844.diff

bridgekeeper · 2021-07-20T19:27:50Z

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-07-20T19:31:15Z

@lmesnik The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-07-20T19:35:03Z

Webrevs

01: Full - Incremental (70e726f3)
00: Full (990bff2f)

lmesnik · 2021-07-20T19:44:35Z

/label hotspot-gc

openjdk · 2021-07-20T19:45:27Z

@lmesnik
The hotspot-gc label was successfully added.

lmesnik · 2021-07-20T19:45:39Z

/label add hotspot-gc

openjdk · 2021-07-20T19:46:37Z

@lmesnik The hotspot-gc label was already applied.

kimbarrett

Some minor commenting issues, but otherwise looks good.

kimbarrett · 2021-07-22T04:19:37Z

test/hotspot/jtreg/vmTestbase/metaspace/stressHierarchy/common/StressHierarchyBaseClass.java

+             * Usually this means that we got OOME:heap while trying to gain OOME:metaspace.
+             * We pass test in this case as this breaks test logic. We have dedicated test configurations
+             * for OOME:heap provoking class unloading, that why we are not missing test coverage here.
+             */


This comment is unnecessary, as it adds nothing over the log message that follows.

Thanks! I just moved it and missed that is the same as the log message.

kimbarrett · 2021-07-22T04:19:37Z

test/hotspot/jtreg/vmTestbase/vm/share/gc/HeapOOMEException.java

- * Usually this means that we got OOME:heap while trying to gain OOME:metaspace.
- * We pass test in this case as this breaks test logic. We have dedicated test configurations
- * for OOME:heap provoking class unloading, that why we are not missing test coverage here.
+ * This class is used to differ OOME in metaspace and heap when trigger class unloading.


That doesn't scan so well. Perhaps something like
"This class is used to distinguish between OOME in metaspace and OOME in heap when triggering class unloading."

openjdk · 2021-07-22T04:21:11Z

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
6096dd9: 8268893: jcmd to trim the glibc heap
c36755d: Merge
89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
e1051ae: 8264066: Enhance compiler validation
add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
ca6b222: 8258432: Improve File Transfers
a3acce5: 8264079: Improve abstractions
138f598: 8262380: Enhance XML processing passes
0e6c011: 8262967: Improve Zip file support
... and 12 more: https://git.openjdk.java.net/jdk/compare/0790f04d8a41aa61b4633e822120d913ec89d900...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

lmesnik · 2021-07-22T18:16:35Z

/integrate

openjdk · 2021-07-22T18:18:25Z

Going to push as commit 258f188.
Since your change was applied there have been 27 commits pushed to the master branch:

3cadc36: 8270336: [TESTBUG] Fix initialization in NonbranchyTree
c2ed336: 8270912: Clean up G1CollectedHeap::process_discovered_references()
8e27d4e: 8271043: Rename G1CollectedHeap::g1mm()
d1257d5: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
50bb731: 8270286: com.sun.net.httpserver.spi.HttpServerProvider: remove use of deprecated API
9131a8f: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails
6096dd9: 8268893: jcmd to trim the glibc heap
c36755d: Merge
89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
e1051ae: 8264066: Enhance compiler validation
... and 17 more: https://git.openjdk.java.net/jdk/compare/0790f04d8a41aa61b4633e822120d913ec89d900...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-22T18:18:46Z

@lmesnik Pushed as commit 258f188.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

lmesnik added 2 commits Jul 20, 2021

8270961

9db8bc4

import fix.

76d53d6

fixed log string.

990bff2

openjdk bot added the rfr label Jul 20, 2021

openjdk bot added the hotspot label Jul 20, 2021

openjdk bot added the hotspot-gc label Jul 20, 2021

Merge branch 'master' of https://github.com/openjdk/jdk into 8270961

af84d26

kimbarrett approved these changes Jul 22, 2021

View changes

openjdk bot added the ready label Jul 22, 2021

fixed after Kim's comments.

70e726f

tschatzl approved these changes Jul 22, 2021

View changes

openjdk bot closed this Jul 22, 2021

openjdk bot added integrated and removed ready rfr labels Jul 22, 2021

lmesnik deleted the 8270961 branch Feb 12, 2022

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

lmesnik commented Jul 20, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

mlbridge bot commented Jul 20, 2021 •

edited

lmesnik commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

lmesnik commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

kimbarrett left a comment

kimbarrett Jul 22, 2021

lmesnik Jul 22, 2021

kimbarrett Jul 22, 2021

openjdk bot commented Jul 22, 2021 •

edited

lmesnik commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

Conversation

lmesnik commented Jul 20, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

mlbridge bot commented Jul 20, 2021 • edited

Webrevs

lmesnik commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

lmesnik commented Jul 20, 2021

openjdk bot commented Jul 20, 2021

kimbarrett left a comment

kimbarrett Jul 22, 2021

Choose a reason for hiding this comment

lmesnik Jul 22, 2021

Choose a reason for hiding this comment

kimbarrett Jul 22, 2021

Choose a reason for hiding this comment

openjdk bot commented Jul 22, 2021 • edited

lmesnik commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

lmesnik commented Jul 20, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Jul 20, 2021 •

edited

openjdk bot commented Jul 22, 2021 •

edited