Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package #4844

Closed
wants to merge 5 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jul 20, 2021

The small refactoring which consolidates shared code in the shared library. Make project more IDE-friendly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4844/head:pull/4844
$ git checkout pull/4844

Update a local copy of the PR:
$ git checkout pull/4844
$ git pull https://git.openjdk.java.net/jdk pull/4844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4844

View PR using the GUI difftool:
$ git pr show -t 4844

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4844.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jul 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2021

Webrevs

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Jul 20, 2021

/label hotspot-gc

@openjdk openjdk bot added the hotspot-gc label Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@lmesnik
The hotspot-gc label was successfully added.

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Jul 20, 2021

/label add hotspot-gc

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@lmesnik The hotspot-gc label was already applied.

Copy link

@kimbarrett kimbarrett left a comment

Some minor commenting issues, but otherwise looks good.

* Usually this means that we got OOME:heap while trying to gain OOME:metaspace.
* We pass test in this case as this breaks test logic. We have dedicated test configurations
* for OOME:heap provoking class unloading, that why we are not missing test coverage here.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is unnecessary, as it adds nothing over the log message that follows.

Copy link
Member Author

@lmesnik lmesnik Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just moved it and missed that is the same as the log message.

* Usually this means that we got OOME:heap while trying to gain OOME:metaspace.
* We pass test in this case as this breaks test logic. We have dedicated test configurations
* for OOME:heap provoking class unloading, that why we are not missing test coverage here.
* This class is used to differ OOME in metaspace and heap when trigger class unloading.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't scan so well. Perhaps something like
"This class is used to distinguish between OOME in metaspace and OOME in heap when triggering class unloading."

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2021
@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Jul 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 258f188.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@lmesnik Pushed as commit 258f188.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8270961 branch Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-gc integrated
3 participants