8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9

[prrace]

These fields

• have not been used by the implementation since JDK8,
• are not supposed to be used by applications,
• have been deprecated for removal since JDK 9
• are non-standard, JDK not Java, classes
• very few clients are expected to be using these classes : just those implementing ATs

The CSR for this is https://bugs.openjdk.java.net/browse/JDK-8270918

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4845/head:pull/4845
$ git checkout pull/4845

Update a local copy of the PR:
$ git checkout pull/4845
$ git pull https://git.openjdk.java.net/jdk pull/4845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4845

View PR using the GUI difftool:
$ git pr show -t 4845

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4845.diff

[prrace]

/csr

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace this pull request will not be integrated until the CSR request JDK-8270918 for issue JDK-8268824 has been approved.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c376e501)
• 00: Full (ba3932f3)

[prrace]

/label swing,awt

[prrace]

Please "review" the CSR too : https://bugs.openjdk.java.net/browse/JDK-8270918

[openjdk]

@prrace
The swing label was successfully added.

The awt label was successfully added.

[mrserb]

Can we rename the "new" "xx_private" fields to the shorter version? The javadoc for the protected fields can be applied to the "private version"(but w/o @deprecated tag).

So in fact we can change "protected" to the "private", drop the "@deprecated" tags, and delete the "xx_private" versions of the fields.

[prrace]

I don't think the javadoc is needed since these are now private fields.
I can however rename them to remove _private.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 296 new commits pushed to the master branch:

• 3ab95d1: 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags
• e2c5bfe: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
• 7234a43: 8271953: fix mis-merge in JDK-8271878
• d7fc9e4: 8267840: Improve URLStreamHandler.parseURL()
• 55bd52a: 8271840: Add simple Integer.toString microbenchmarks
• 18dd4d4: 8271121: ZGC: stack overflow (segv) when -Xlog:gc+start=debug
• 685fc3c: 8270903: sun.net.httpserver.HttpConnection: Improve toString
• 4abe531: 8271722: [TESTBUG] gc/g1/TestMixedGCLiveThreshold.java can fail if G1 Full GC uses >1 workers
• ea9a595: 8270058: Use Objects.check{Index,FromIndexSize} for java.desktop
• 64d18d4: 4819544: SwingSet2 JTable Demo throws NullPointerException
• ... and 286 more: https://git.openjdk.java.net/jdk/compare/ca806ef31970e2d020e631d55b44cfe30e11c5ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit 4548677.
Since your change was applied there have been 323 commits pushed to the master branch:

• b53828b: 8272047: java/nio/channels/FileChannel/Transfer2GPlus.java failed with Unexpected transfer size: 2147418112
• 41dc795: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
• 9c6457f: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
• 0ac2be9: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
• 272fcb4: 8272113: Build compare script fails with differences in classlist
• 2f7a469: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling
• a86ac0d: 8271939: Clean up primitive raw accessors in oopDesc
• b84a9c7: 8271956: AArch64: C1 build failed after JDK-8270947
• 38ff85c: 8271461: CompileCommand support for hidden class methods
• c495ede: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
• ... and 313 more: https://git.openjdk.java.net/jdk/compare/ca806ef31970e2d020e631d55b44cfe30e11c5ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 4548677.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.