Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert #4847

Closed
wants to merge 3 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jul 20, 2021

Update the test certificates.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4847/head:pull/4847
$ git checkout pull/4847

Update a local copy of the PR:
$ git checkout pull/4847
$ git pull https://git.openjdk.java.net/jdk pull/4847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4847

View PR using the GUI difftool:
$ git pr show -t 4847

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4847.diff

…ation/ComodoCA.java fails due to revoked cert
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jul 20, 2021
@openjdk openjdk bot added the rfr label Jul 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@rhalade this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8263059
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict label Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels Jul 30, 2021
@rhalade
Copy link
Member Author

@rhalade rhalade commented Jul 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

Going to push as commit 4bc9b04.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added the integrated label Jul 30, 2021
@rhalade rhalade deleted the 8263059 branch Jul 30, 2021
@openjdk openjdk bot removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@rhalade Pushed as commit 4bc9b04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants