Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270991: G1 Full GC always performs heap verification after JDK-8269295 #4856

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 21, 2021

Hi all,

can I have reviews for this fix that removes always-on heap verification for g1 full gcs caused by any reason?

JDK-8269295 refactored some code in that area, and existing tests only checked that verification is properly enabled or disabled for young gc only.

This change fixes the problem and improves the existing test accordingly.

Testing: new test case

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270991: G1 Full GC always performs heap verification after JDK-8269295

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4856/head:pull/4856
$ git checkout pull/4856

Update a local copy of the PR:
$ git checkout pull/4856
$ git pull https://git.openjdk.java.net/jdk pull/4856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4856

View PR using the GUI difftool:
$ git pr show -t 4856

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4856.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 21, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2021

Webrevs

Copy link
Member

@walulyai walulyai left a comment

Lgtm!

Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 21, 2021

Consider pushing this without waiting for the usual HotSpot 24 hour rule.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270991: G1 Full GC always performs heap verification after JDK-8269295

Reviewed-by: iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 21, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jul 21, 2021

I'll push forgoing the 24 hour rule since it is a very small fix, and fairly disruptive when benchmarking.

Thanks @kimbarrett and @walulyai for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

Going to push as commit 57611b3.

@openjdk openjdk bot closed this Jul 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@tschatzl Pushed as commit 57611b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8270991-full-gc-always-verifies branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants